From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55622)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d2KTa-0002fq-3C
	for guix-patches@gnu.org; Sun, 23 Apr 2017 12:35:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d2KTW-0000Sw-W7
	for guix-patches@gnu.org; Sun, 23 Apr 2017 12:35:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38437)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d2KTW-0000Sj-RU
	for guix-patches@gnu.org; Sun, 23 Apr 2017 12:35:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d2KTW-0005oG-K0
	for guix-patches@gnu.org; Sun, 23 Apr 2017 12:35:02 -0400
Subject: bug#26339: [PATCH v2 10/12] scripts: system: Adapt "init" to new
	bootloader API.
Resent-Message-ID: <handler.26339.B26339.149296527622291@debbugs.gnu.org>
References: <20170417090148.13791-1-m.othacehe@gmail.com>
	<20170417090148.13791-11-m.othacehe@gmail.com>
	<20170423103929.79d0595c@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170423103929.79d0595c@scratchpost.org>
Date: Sun, 23 Apr 2017 18:34:25 +0200
Message-ID: <87h91fdqwe.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26339@debbugs.gnu.org


> "installer" instead of "install-proc" ?

Ok for "installer".

>> +      (maybe-copy
>> +       (derivation->output-path bootcfg))
>
> Does derivation->output-path change anything?

Well I guess yes, because maybe-copy is expecting a path and not a
derivation.

>
>>+                      #:bootloader? bootloader?
>
> What about the bootloader? :)
>
> "install-bootloader?" ?

Ok for install-bootloader? :)

>
>>+                      #:install-proc
>
> #:bootloader-installer ?

Seems ok to me.

>
> Otherwise LGTM!

Thanks, I'll publish a rebased version, maybe when your own bootloader
serie will be pushed !

Mathieu