From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRvur-0004Df-9Q for guix-patches@gnu.org; Mon, 03 Jul 2017 03:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRvuo-0000AA-5i for guix-patches@gnu.org; Mon, 03 Jul 2017 03:37:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRvuo-0000A1-23 for guix-patches@gnu.org; Mon, 03 Jul 2017 03:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRvun-00081s-O1 for guix-patches@gnu.org; Mon, 03 Jul 2017 03:37:01 -0400 Subject: [bug#27542] [PATCH] gnu: gcr: Enable working tests. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170630214326.27709-1-kei@openmailbox.org> <87shie7u9l.fsf@gnu.org> <87podiiqr6.fsf@openmailbox.org> <87shie4n1e.fsf@gnu.org> <87lgo68qjy.fsf@openmailbox.org> Date: Mon, 03 Jul 2017 09:35:03 +0200 In-Reply-To: <87lgo68qjy.fsf@openmailbox.org> (Kei Kebreau's message of "Sun, 02 Jul 2017 17:41:37 -0400") Message-ID: <87h8yurn14.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: 27542@debbugs.gnu.org Kei Kebreau skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Kei Kebreau skribis: >> >>> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>> >>>> Hello, >>>> >>>> Kei Kebreau skribis: >>>> >>>>> * gnu/packages/patches/gcr-disable-failing-tests.patch, >>>>> gnu/packages/patches/gcr-fix-collection-tests-to-work-with-gpg-21.pat= ch: >>>>> New files. >>>>> * gnu/local.mk (dist_patch_DATA): Add patches. >>>>> * gnu/packages/gnome.scm (gcr)[source]: Use patches. >>>>> [arguments]: Enable tests. >>>> >>>> [...] >>>> >>>>> +++ b/gnu/packages/patches/gcr-disable-failing-tests.patch >>>>> @@ -0,0 +1,127 @@ >>>>> +This patch removes a group of tests that fail because >>>>> /var/lib/dbus/machine-id >>>>> +is not present in the build environment. >>>> >>>> We usually work around these with: >>>> >>>> (setenv "DBUS_FATAL_WARNINGS" "0") >>>> >>>> Is it ineffective here? >>>> >>> >>> That's good to know, but it doesn't seem to work in this case. I get 18 >>> test failures all from the same group mentioning the missing >>> 'machine-id' file. >> >> Are they really errors and not just warnings (the errors being something >> else)? >> >> Also, could it be that some Makefile or script forcefully sets >> DBUS_FATAL_WARNINGS to 1, as is the case in =E2=80=98python-dbus=E2=80= =99? >> > > I see no such setting. OK. In that case your patch looks like the right thing to me. Thank you, and sorry for introducing more delay! Ludo=E2=80=99.