From: ludo@gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei@openmailbox.org>
Cc: 27542@debbugs.gnu.org
Subject: [bug#27542] [PATCH] gnu: gcr: Enable working tests.
Date: Mon, 03 Jul 2017 09:35:03 +0200 [thread overview]
Message-ID: <87h8yurn14.fsf@gnu.org> (raw)
In-Reply-To: <87lgo68qjy.fsf@openmailbox.org> (Kei Kebreau's message of "Sun, 02 Jul 2017 17:41:37 -0400")
Kei Kebreau <kei@openmailbox.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Kei Kebreau <kei@openmailbox.org> skribis:
>>
>>> ludo@gnu.org (Ludovic Courtès) writes:
>>>
>>>> Hello,
>>>>
>>>> Kei Kebreau <kei@openmailbox.org> skribis:
>>>>
>>>>> * gnu/packages/patches/gcr-disable-failing-tests.patch,
>>>>> gnu/packages/patches/gcr-fix-collection-tests-to-work-with-gpg-21.patch:
>>>>> New files.
>>>>> * gnu/local.mk (dist_patch_DATA): Add patches.
>>>>> * gnu/packages/gnome.scm (gcr)[source]: Use patches.
>>>>> [arguments]: Enable tests.
>>>>
>>>> [...]
>>>>
>>>>> +++ b/gnu/packages/patches/gcr-disable-failing-tests.patch
>>>>> @@ -0,0 +1,127 @@
>>>>> +This patch removes a group of tests that fail because
>>>>> /var/lib/dbus/machine-id
>>>>> +is not present in the build environment.
>>>>
>>>> We usually work around these with:
>>>>
>>>> (setenv "DBUS_FATAL_WARNINGS" "0")
>>>>
>>>> Is it ineffective here?
>>>>
>>>
>>> That's good to know, but it doesn't seem to work in this case. I get 18
>>> test failures all from the same group mentioning the missing
>>> 'machine-id' file.
>>
>> Are they really errors and not just warnings (the errors being something
>> else)?
>>
>> Also, could it be that some Makefile or script forcefully sets
>> DBUS_FATAL_WARNINGS to 1, as is the case in ‘python-dbus’?
>>
>
> I see no such setting.
OK. In that case your patch looks like the right thing to me.
Thank you, and sorry for introducing more delay!
Ludo’.
next prev parent reply other threads:[~2017-07-03 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 21:43 [bug#27542] [PATCH] gnu: gcr: Enable working tests Kei Kebreau
2017-07-02 15:06 ` Ludovic Courtès
2017-07-02 19:27 ` Kei Kebreau
2017-07-02 20:11 ` Ludovic Courtès
2017-07-02 21:41 ` Kei Kebreau
2017-07-03 7:35 ` Ludovic Courtès [this message]
2017-07-03 13:54 ` bug#27542: " Kei Kebreau
2017-07-03 20:24 ` [bug#27542] " Roel Janssen
2017-07-03 22:45 ` Kei Kebreau
2017-07-04 6:51 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8yurn14.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27542@debbugs.gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).