From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45248)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dT7sx-00081e-34
	for guix-patches@gnu.org; Thu, 06 Jul 2017 10:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dT7sw-0005il-7p
	for guix-patches@gnu.org; Thu, 06 Jul 2017 10:36:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:52587)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dT7sw-0005iP-2d
	for guix-patches@gnu.org; Thu, 06 Jul 2017 10:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dT7sv-0005V3-SB
	for guix-patches@gnu.org; Thu, 06 Jul 2017 10:36:01 -0400
Subject: [bug#27596] [PATCH] guix: lint: Add checker for new upstream versions.
Resent-Message-ID: <handler.27596.B27596.149935175421127@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170706101723.3349-1-efraim@flashner.co.il>
Date: Thu, 06 Jul 2017 16:35:38 +0200
In-Reply-To: <20170706101723.3349-1-efraim@flashner.co.il> (Efraim Flashner's
	message of "Thu, 6 Jul 2017 13:17:23 +0300")
Message-ID: <87h8ypocp1.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 27596@debbugs.gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> * guix/scripts/lint.scm (check-for-updates): New procedure.
> (%checkers): Add it.

Good idea.

> +(define (check-for-updates package)
> +  "Check if there is an update available for PACKAGE."
> +  (guix-refresh (package-name package)))

I think we should use the (guix upstream) API directly because
=E2=80=98guix-refresh=E2=80=99 can call =E2=80=98exit=E2=80=99 and it forma=
ts messages in a way that is
not consistent with the rest of =E2=80=98guix lint=E2=80=99.

To do that I think we=E2=80=99ll first have to move =E2=80=98%updaters=E2=
=80=99 to (guix
upstream), probably turning it into a procedure.

WDYT?

Thanks,
Ludo=E2=80=99.