From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY7cr-0008GV-PO for guix-patches@gnu.org; Thu, 20 Jul 2017 05:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dY7co-00048u-J9 for guix-patches@gnu.org; Thu, 20 Jul 2017 05:20:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dY7co-00048a-FY for guix-patches@gnu.org; Thu, 20 Jul 2017 05:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dY7co-0000Xx-9n for guix-patches@gnu.org; Thu, 20 Jul 2017 05:20:02 -0400 Subject: [bug#27691] Tabs and patches names Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170714124108.24997-1-go.wigust@gmail.com> <87poczcaxz.fsf@magnolia.i-did-not-set--mail-host-address--so-tickle-me> Date: Thu, 20 Jul 2017 11:19:08 +0200 In-Reply-To: <87poczcaxz.fsf@magnolia.i-did-not-set--mail-host-address--so-tickle-me> (Oleg Pykhalov's message of "Mon, 17 Jul 2017 18:58:16 +0300") Message-ID: <87h8y7xy7n.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 27691@debbugs.gnu.org Hi Oleg, Oleg Pykhalov skribis: >>>From 39f61dbcc0b7b09a325536149eee6c69c7526b4e Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Fri, 14 Jul 2017 15:34:33 +0300 > Subject: [PATCH] gnu: Add tome4. > > * gnu/packages/games.scm (tome4): New variable. Please add the patches to gnu/local.mk. > + (substitute* "tome4.desktop" > + (("Exec=3D/usr") > + (string-append "Exec=3D" > + (assoc-ref outputs "out") > + "/usr"))) Is it needed? I would expect the =E2=80=98patch-dot-desktop-files=E2=80=99= to do the right thing. > + (synopsis "Roguelike RPG") > + (description "Tales of Maj=E2=80=99Eyal (ToME) is a free, open sourc= e roguelike Please remove =E2=80=9Cfree, open source=E2=80=9D: that=E2=80=99s always th= e case in Guix. :-) > diff --git a/gnu/packages/patches/tome4-add-desktop-file.patch b/gnu/pack= ages/patches/tome4-add-desktop-file.patch > new file mode 100644 > index 000000000..80fd82478 > --- /dev/null > +++ b/gnu/packages/patches/tome4-add-desktop-file.patch > @@ -0,0 +1,27 @@ > +From b8e207e145938f7a0f23d1c5107d532ebb9de720 Mon Sep 17 00:00:00 2001 > +From: Oleg Pykhalov > +Date: Fri, 14 Jul 2017 11:19:37 +0300 > +Subject: [PATCH] Add desktop file. > + > +--- > + tome4.desktop | 8 ++++++++ > + 1 file changed, 8 insertions(+) > + create mode 100644 tome4.desktop > + > +diff --git a/tome4.desktop b/tome4.desktop > +new file mode 100644 > +index 000000000..c5d67f0cf > +--- /dev/null > ++++ b/tome4.desktop > +@@ -0,0 +1,8 @@ > ++[Desktop Entry] > ++Name=3DToME4 > ++Comment=3DAn open-source, single-player, role-playing roguelike game se= t in the world of Eyal. > ++Exec=3D/usr/bin/tome4 > ++Icon=3Dtome4.png > ++Terminal=3Dfalse > ++Type=3DApplication > ++Categories=3DGame;RolePlaying; For each patch, could you write a line explaining whether they are upstream patches, to simplify future updates? Also, please remove =E2=80=9Copen-source=E2=80=9D from the comment. (BTW I= recommend .) > @@ -0,0 +1,23 @@ > +From f10d89912989e0f071855ab2c20d62b318d313fc Mon Sep 17 00:00:00 2001 > +From: Oleg Pykhalov > +Date: Fri, 14 Jul 2017 11:17:26 +0300 > +Subject: [PATCH] Add shell wrapper for launching. > + > +--- > + tome4 | 4 ++++ > + 1 file changed, 4 insertions(+) > + create mode 100644 tome4 > + > +diff --git a/tome4 b/tome4 > +new file mode 100644 > +index 000000000..2b623e467 > +--- /dev/null > ++++ b/tome4 > +@@ -0,0 +1,4 @@ > ++#!/usr/bin/sh > ++cd "/opt/tome4" > ++./t-engine & > ++exit If this is not an upstream patch, I would find it nicer to create the wrapper directly from the build phase, and with the right directory name instead of =E2=80=9C/opt=E2=80=9D. Could you send an updated patch? Thank you! Ludo=E2=80=99.