From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djoO2-0008LJ-7E for guix-patches@gnu.org; Mon, 21 Aug 2017 11:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djoNy-00077u-N7 for guix-patches@gnu.org; Mon, 21 Aug 2017 11:13:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djoNy-00077n-Iz for guix-patches@gnu.org; Mon, 21 Aug 2017 11:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djoNy-0000p8-Au for guix-patches@gnu.org; Mon, 21 Aug 2017 11:13:02 -0400 Subject: [bug#27905] changes for openmpi Resent-Message-ID: From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87zibja1of.fsf@i-ulialbion.it.manchester.ac.uk> Date: Mon, 21 Aug 2017 17:12:06 +0200 In-Reply-To: <87zibja1of.fsf@i-ulialbion.it.manchester.ac.uk> (Dave Love's message of "Tue, 01 Aug 2017 13:54:24 +0100") Message-ID: <87h8x1t0op.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Dave Love Cc: 27905@debbugs.gnu.org Hi! I=E2=80=99ve applied most of the patches. I have a few remaining questions: Dave Love skribis: >>>From 67a59e734dd451d1e64d450dcebeb23d60996f3e Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Mon, 31 Jul 2017 14:58:39 +0100 > Subject: [PATCH] gnu: hwloc: Replace "lib" output with "nogui", containin= g=20 > all but lstopo. > > A compute node typically wants the non-GUI programs available, which still > have a small closure. > > * mpi.scm (hwloc)[outputs]: Replace lib with nogui. > (hwloc)[arguments]: Change configure --prefix; use "nogui" output, > not "lib"; populate "all" output. > (openmpi)[inputs]: Use hwloc-nogui. The downside of this is that the =E2=80=9Cnogui=E2=80=9D output is less dis= coverable (and it=E2=80=99s another user-visible breakage.) Also, it shouldn=E2=80=99t make any difference to the closure size of openm= pi anyway, no? >>>From 1772aa47c3bc71521340d7f569d4d906ab7f53e9 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Mon, 31 Jul 2017 15:01:59 +0100 > Subject: [PATCH] gnu: valgrind: Add "doc" and "openmpi" outputs. > > Also don't configure openmpi with valgrind; rely on the wrapper > library from the valgrind package, like Fedora and Debian. > > * gnu/packages/valgrind.scm (valgrind)[outputs]: New field. > [arguments]: Add install-doc and install-openmpi phases. > [description]: Mention openmpi output. > * gnu/packages/mpi.scm (openmpi)[arguments]: Don't configure with > valgrind. I=E2=80=99ve installed the doc-output-for-valgrind part, as a separate patc= h. Regarding the rest: > + (add-after 'install 'install-openmpi > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((dest (format #f "~a/lib/valgrind" > + (assoc-ref outputs "openmpi")))) > + (mkdir-p dest) > + (zero? > + (system (format #f "mv ~a/lib/valgrind/libmpiwrap* ~a" > + (assoc-ref outputs "out") dest))))))))) Why move it to a separate output? After all, we can keep it in =E2=80=9Cou= t=E2=80=9D since all it costs is the size of libmpiwrap.so, right? Also, I assume that this is functionally equivalent to Open MPI=E2=80=99s built-in Valgrind support, is it? >>>From ec65c9d847c30d51bf83b49b397bc1ca20b7ca11 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Mon, 31 Jul 2017 17:15:19 +0100 > Subject: [PATCH 8/8] gnu: openmpi: Remove references to compiler pathname= s in > "_info" programs. > > This reduces the closure greatly, but note that the Fortran .mod files are > gfortran version-specific, so there should probably be development packag= es > for each incompatible version. (The runtime is supposed to be more-or-le= ss > version-independent unless the libgfortran soname changes.) There may st= ill > be a case for a separate runtime output. > > * gnu/packages/mpi.scm (openmpi)[arguments]: Add "remove-absolute" phase. Great, I added the URL of previous discussions on this topic. With the changes I pushed the closure size is already at 378.5 instead of 700.8 MiB, pretty cool! Thank you, Ludo=E2=80=99.