[bug#28126] [PATCH 0/1] gnu: Add emacs-browse-at-remote.

[bug#28126] [PATCH 0/1] gnu: Add emacs-browse-at-remote.

[Oleg Pykhalov]

Hello Guix,

I tried to ask an upstream to provide a release tarball, but no answer still.
https://github.com/rmuslimov/browse-at-remote/issues/40

Is string-join and dired-current-directory warning important?

--8<---------------cut here---------------start------------->8---
In end of data:
browse-at-remote.el:363:1:Warning: the following functions are not known to be
    defined: string-join, dired-current-directory
--8<---------------cut here---------------end--------------->8---

string-join defined in
/gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/emacs-lisp/subr-x.el.gz

dired-current-directory defined in
/gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/dired.el.gz

Thanks!

Oleg Pykhalov (1):
  gnu: Add emacs-browse-at-remote.

 gnu/packages/emacs.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

-- 
2.14.1

[bug#28126] [PATCH 1/1] gnu: Add emacs-browse-at-remote.

[Oleg Pykhalov]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH 1/1] gnu: Add emacs-browse-at-remote. --]
[-- Type: text/x-patch, Size: 3211 bytes --]

From 32a917cb337dbb25010d687f21b3d305eb01a852 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Thu, 17 Aug 2017 20:35:43 +0300
Subject: [PATCH 1/1] gnu: Add emacs-browse-at-remote.

* gnu/packages/emacs.scm (emacs-browse-at-remote): New variable.
---
 gnu/packages/emacs.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 1728b5b92..faa131812 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5380,3 +5380,54 @@ enables you to easily define search engines, bind them to keybindings, and
 query them from the comfort of your editor.")
     (home-page "https://github.com/hrs/engine-mode")
     (license license:gpl3+)))
+
+(define-public emacs-browse-at-remote
+  (let ((commit "b5cff7971ca8bbb966e3acd9b7e5c4c007f94215")
+        (revision "1"))
+    (package
+      (name "emacs-browse-at-remote")
+      (version (string-append "0.9.0-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/rmuslimov/browse-at-remote.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "16ms9703m15dfxg6ap4mdw7msf8z5rzsdhba51dwivfpjxg7n52c"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-f" ,emacs-f)
+         ("emacs-s" ,emacs-s)
+         ("emacs-dash" ,emacs-dash)))
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-before 'install 'check
+             (lambda* (#:key inputs #:allow-other-keys)
+               (zero? (system* "emacs" "--batch" "-L" "."
+                               "-L" (string-append
+                                     (assoc-ref inputs "emacs-f")
+                                     "/share/emacs/site-lisp/guix.d/f-"
+                                     ,(package-version emacs-f))
+                               "-L" (string-append
+                                     (assoc-ref inputs "emacs-s")
+                                     "/share/emacs/site-lisp/guix.d/s-"
+                                     ,(package-version emacs-s))
+                               "-L" (string-append
+                                     (assoc-ref inputs "emacs-dash")
+                                     "/share/emacs/site-lisp/guix.d/dash-"
+                                     ,(package-version emacs-dash))
+                               "-l" "test/api-basic-test.el"
+                               "-f" "ert-run-tests-batch-and-exit")))))))
+      (home-page "https://github.com/rmuslimov/browse-at-remote")
+      (synopsis
+       "Open github/gitlab/bitbucket/stash page from Emacs")
+      (description
+       "Easily open target page on github/gitlab (or bitbucket) from Emacs by
+calling @code{browse-at-remote} function.  Support dired buffers and opens
+them in tree mode at destination.
+")
+      (license license:gpl3+))))
-- 
2.14.1

[bug#28126] [PATCH 0/1] gnu: Add emacs-browse-at-remote.

[Alex Kost]

Oleg Pykhalov (2017-08-17 21:00 +0300) wrote:

> Hello Guix,

Hello, and sorry for the very long delay.

> I tried to ask an upstream to provide a release tarball, but no answer still.
> https://github.com/rmuslimov/browse-at-remote/issues/40

I see you were not the first who asked about it, there is already:

https://github.com/rmuslimov/browse-at-remote/issues/37

> Is string-join and dired-current-directory warning important?
>
> In end of data:
> browse-at-remote.el:363:1:Warning: the following functions are not known to be
>     defined: string-join, dired-current-directory
>
> string-join defined in
> /gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/emacs-lisp/subr-x.el.gz
>
> dired-current-directory defined in
> /gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/dired.el.gz

No, these warnings are not important.  Anyway, it's the upstream job to
take care about such compilation warnings.

-- 
Alex

bug#28126: [PATCH 1/1] gnu: Add emacs-browse-at-remote.

[Alex Kost]

Oleg Pykhalov (2017-08-17 21:20 +0300) wrote:

>>From 32a917cb337dbb25010d687f21b3d305eb01a852 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Thu, 17 Aug 2017 20:35:43 +0300
> Subject: [PATCH 1/1] gnu: Add emacs-browse-at-remote.
>
> * gnu/packages/emacs.scm (emacs-browse-at-remote): New variable.
> ---
>  gnu/packages/emacs.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 1728b5b92..faa131812 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -5380,3 +5380,54 @@ enables you to easily define search engines, bind them to keybindings, and
>  query them from the comfort of your editor.")
>      (home-page "https://github.com/hrs/engine-mode")
>      (license license:gpl3+)))
> +
> +(define-public emacs-browse-at-remote
> +  (let ((commit "b5cff7971ca8bbb966e3acd9b7e5c4c007f94215")
> +        (revision "1"))
> +    (package
> +      (name "emacs-browse-at-remote")
> +      (version (string-append "0.9.0-" revision "."
> +                              (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/rmuslimov/browse-at-remote.git")
> +                      (commit commit)))
> +                (file-name (string-append name "-" version "-checkout"))
> +                (sha256
> +                 (base32
> +                  "16ms9703m15dfxg6ap4mdw7msf8z5rzsdhba51dwivfpjxg7n52c"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +       `(("emacs-f" ,emacs-f)
> +         ("emacs-s" ,emacs-s)
> +         ("emacs-dash" ,emacs-dash)))

This package does not require "dash", so I removed it from here...

> +      (arguments
> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (add-before 'install 'check
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (zero? (system* "emacs" "--batch" "-L" "."
> +                               "-L" (string-append
> +                                     (assoc-ref inputs "emacs-f")
> +                                     "/share/emacs/site-lisp/guix.d/f-"
> +                                     ,(package-version emacs-f))
> +                               "-L" (string-append
> +                                     (assoc-ref inputs "emacs-s")
> +                                     "/share/emacs/site-lisp/guix.d/s-"
> +                                     ,(package-version emacs-s))
> +                               "-L" (string-append
> +                                     (assoc-ref inputs "emacs-dash")
> +                                     "/share/emacs/site-lisp/guix.d/dash-"
> +                                     ,(package-version emacs-dash))

... and here.

> +                               "-l" "test/api-basic-test.el"
> +                               "-f" "ert-run-tests-batch-and-exit")))))))

Wow, you even made the phase to run tests!  To be honest, I wouldn't
bother about it :-)  (but don't tell it anyone)

> +      (home-page "https://github.com/rmuslimov/browse-at-remote")
> +      (synopsis
> +       "Open github/gitlab/bitbucket/stash page from Emacs")
> +      (description
> +       "Easily open target page on github/gitlab (or bitbucket) from Emacs by
> +calling @code{browse-at-remote} function.  Support dired buffers and opens
> +them in tree mode at destination.
> +")
> +      (license license:gpl3+))))

I have adjusted the description a bit and committed:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=eaf4ba6ef3319ca6b4eeb5cf5021768f7b438934

Thank you!

-- 
Alex

[bug#28126] [PATCH 1/1] gnu: Add emacs-browse-at-remote.

[Oleg Pykhalov]

Hello Alex,

Alex Kost <alezost@gmail.com> writes:

…

> This package does not require "dash", so I removed it from here...

It requires according to build logs, http://hydra.gnu.org/build/2253531/log/raw

…

bug#28126: [PATCH 1/1] gnu: Add emacs-browse-at-remote.

[Alex Kost]

Oleg Pykhalov (2017-09-04 11:39 +0300) wrote:

> Hello Alex,
>
> Alex Kost <alezost@gmail.com> writes:
>
> …
>> This package does not require "dash", so I removed it from here...
>
> It requires according to build logs, http://hydra.gnu.org/build/2253531/log/raw

Oops, indeed.  I thought I tested the modified version of your patch,
but apparently I built your original patch, that's why the build was
successful for me.  Thank you for pointing!

At first I was confused, as "browse-at-remote" does not require "dash".
But then I realized where this "dash" dependency comes from:
"browse-at-remote" requires "f" and "f" requires "dash".

So "dash" is not needed to be in 'propagated-inputs' (as it is
propagated by "f").  As for the tests, I realized that this package is
intended to use 'ert-runner' to run the tests, so using it simplifies
the 'check' phase:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=8505d34829b99744a36d72dd583768f1e49210a6

Hopefully, it will be built successfully this time :-)

-- 
Alex