From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6Ouc-0004sF-Sz
	for guix-patches@gnu.org; Sun, 22 Oct 2017 18:40:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6OuY-0008Ea-W2
	for guix-patches@gnu.org; Sun, 22 Oct 2017 18:40:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47682)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e6OuY-0008ER-Sn
	for guix-patches@gnu.org; Sun, 22 Oct 2017 18:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e6OuY-0007b0-KD
	for guix-patches@gnu.org; Sun, 22 Oct 2017 18:40:02 -0400
Subject: [bug#28913] [PATCH 2/2] gnu: Add criu.
Resent-Message-ID: <handler.28913.B28913.150871199629180@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171021005556.28993-1-rekado@elephly.net>
	<20171021005556.28993-2-rekado@elephly.net>
Date: Sun, 22 Oct 2017 15:39:44 -0700
In-Reply-To: <20171021005556.28993-2-rekado@elephly.net> (Ricardo Wurmus's
	message of "Sat, 21 Oct 2017 02:55:56 +0200")
Message-ID: <87h8uqyfgv.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 28913@debbugs.gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/virtualization.scm (criu): New variable.

[...]

> +         (replace 'configure
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             ;; The includes for libnl are located in a sub-directory.
> +             (setenv "C_INCLUDE_PATH"
> +                     (string-append (assoc-ref inputs "libnl")
> +                                    "/include/libnl3:"
> +                                    (getenv "C_INCLUDE_PATH")))

And there=E2=80=99s no libnet.pc or similar to provide the right -I flag?

> +    (synopsis "Checkpoint and restore in userspace")

=E2=80=9Cuser space=E2=80=9D (two words)?

Otherwise LGTM, thank you!

Ludo=E2=80=99.