unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Rutger Helling <rhelling@mykolab.com>, 29155-done@debbugs.gnu.org
Subject: bug#29155: [PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland	backend.
Date: Sun, 05 Nov 2017 18:20:14 +0100	[thread overview]
Message-ID: <87h8u8fxrl.fsf@fastmail.com> (raw)
In-Reply-To: <55e11bbb331138bb5d92f6c862bba95b@mykolab.com>

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]

Rutger Helling <rhelling@mykolab.com> writes:

> Hey Guix, 
>
> this patch updates SDL2 to 2.0.7 and enables the Wayland backend.

Excellent!

> From 8121e1100d56cbafa23a255fa6bd4f8c5b4fc7d3 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Sun, 5 Nov 2017 12:01:04 +0100
> Subject: [PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland backend.
>
> * gnu/packages/sdl.scm (sdl2): Update to 2.0.7.
> * gnu/packages/sdl.scm (sdl2)[inputs]: Add wayland, wayland-protocols, libxkbcommon.

This forgot to mention the change to [arguments].

> @@ -94,7 +97,7 @@ joystick, and graphics hardware.")
>  (define-public sdl2
>    (package (inherit sdl)
>      (name "sdl2")
> -    (version "2.0.5")
> +    (version "2.0.7")
>      (source (origin
>               (method url-fetch)
>               (uri
> @@ -102,7 +105,21 @@ joystick, and graphics hardware.")
>                               version ".tar.gz"))
>               (sha256
>                (base32
> -               "11c75qj1qxmx67iwkvf9z4x69phk301pdn86zzr6jncnap7kh824"))))
> +               "0pjdpxla5kh1w1b0shxrx97a116vyy31njxi0jhyvqhk8d6cfdgf"))))
> +    (arguments
> +     '(;; Explicitly link against shared libraries instead of dlopening them.
> +       ;; For X11, ALSA, PulseAudio and Wayland.
> +       ;; OpenGL library is still dlopened at runtime.
> +       #:configure-flags '("--disable-alsa-shared"
> +                           "--disable-pulseaudio-shared"
> +                           "--disable-x11-shared"
> +                           "--disable-wayland-shared"

I changed this section to inherit from 'sdl' and just add the wayland
flag, and updated the commit message accordingly.

> @@ -111,7 +128,10 @@ joystick, and graphics hardware.")
>       (append `(("dbus" ,dbus)
>                 ("fcitx" ,fcitx) ; helps with CJK input
>                 ("glib" ,glib)
> -               ("ibus" ,ibus))
> +               ("ibus" ,ibus)
> +               ("wayland", wayland)
> +               ("wayland-protocols", wayland-protocols)
> +               ("libxkbcommon", libxkbcommon))

And also restored the alphabetical ordering here to please the OCD.

Pushed as 39f2433c39b3cb6d1e4c0f04e8b735c181d6feac, thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2017-11-05 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 11:28 [bug#29155] [PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland backend Rutger Helling
2017-11-05 17:20 ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8u8fxrl.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=29155-done@debbugs.gnu.org \
    --cc=rhelling@mykolab.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).