From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enZGT-0002aH-B2 for guix-patches@gnu.org; Sun, 18 Feb 2018 19:25:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enZGQ-0008Vs-3w for guix-patches@gnu.org; Sun, 18 Feb 2018 19:25:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enZGP-0008VL-Ub for guix-patches@gnu.org; Sun, 18 Feb 2018 19:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1enZGP-0002pQ-Oa for guix-patches@gnu.org; Sun, 18 Feb 2018 19:25:01 -0500 Subject: [bug#30492] [PATCH 3/4] gnu: Add wxwidgets@2.8. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180218223344.5a7de7ca@alma-ubu> References: <20180216220913.08cc8ca0@alma-ubu> <20180216222004.0dfa956f@alma-ubu> <87efliteed.fsf@fastmail.com> <20180218223344.5a7de7ca@alma-ubu> Date: Mon, 19 Feb 2018 01:24:18 +0100 Message-ID: <87h8qdddxp.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 30492@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > On Sun, 18 Feb 2018 18:07:38 +0100 > Marius Bakke wrote: > >> Bj=C3=B6rn H=C3=B6fling writes: >>=20 >> > * gnu/packages/wxwidgets.scm (wxwidgets-2.8): New variable.=20=20 >>=20 >> This is effectively a revert of >> 6f9ba4c91c096a2fb95da111be0657d99ef2b683. However, it does some >> things differently, can you have a look and see if this patch needs >> adjustment? >>=20 >> [...] >>=20=20=20 >> > +(define-public wxwidgets-2.8 >> > + (package (inherit wxwidgets) >> > + (version "2.8.12") >> > + (source >> > + (origin >> > + (method url-fetch) >> > + (uri (string-append >> > "https://github.com/wxWidgets/wxWidgets/archive/v" >> > + version ".tar.gz"))=20=20 >>=20 >> wxWidgets provides "release" tarballs which are preferred to the >> auto-generated git archive tarballs. See the above-mentioned commit >> for the proper URL :-) > > Thanks Marius for reviewing that series. > > I did not know that there was already a 2.8-version and haven't looked > into history. I copied the non-release URL from 3.1, which isn't > released yet :-) > > I think I will just revert the commit you mentioned, as this worked > and was there in the past. How do I revert that, concerning the commit > message: Do I write a full, normal commmit like > "gnu/package/wxwidgets.scm: Add new variable"? Should I mention the > revert? Is it legitimate/necessary to add my copyright header, > although I haven't contributed any line?! Just the commit generated by "git revert" is fine IMO. Thanks for packaging these! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqKGTIACgkQoqBt8qM6 VPqHNwf+JhIlOx6dAhgR3jYKT3ODWLgs138vfiB6Omeb6cndKMzm+pptaZTw4Hm9 hAdAZHRxbyQbUkylYwV/vFzcVaoyLjXXgJAXQ7SHwYm8nsb9+j/MM+5uxAVvphKj vg+4XKmXuZR0KzPKN3c5q1Zkwc+Bpv0RB+dqwPr5LnaM4GnBHIdZkYf8Ump/2Tg6 l3j2iwHiIfMbhGtFvIxB1fkWIAj6T7DE3Wmr8QHajPYndEYubJO9TZsiAjy+bexj 4SNuhGMWYUVHvFey3GjZ8+FriKfEnWnSHuY+0j859TcTRkvlukliifqZH24s9jMm yiI6xl1+Ycp2yhGy7tqhLeGU58uUWA== =SaL6 -----END PGP SIGNATURE----- --=-=-=--