From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqbsg-0008Kw-Fu for guix-patches@gnu.org; Tue, 27 Feb 2018 04:49:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqbsc-0002s0-Ip for guix-patches@gnu.org; Tue, 27 Feb 2018 04:49:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqbsc-0002rs-DY for guix-patches@gnu.org; Tue, 27 Feb 2018 04:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eqbsc-00031L-6l for guix-patches@gnu.org; Tue, 27 Feb 2018 04:49:02 -0500 Subject: [bug#29732] [PATCH 0/1] Add a DHCP daemon service Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171216083528.2081-1-cmmarusich@gmail.com> <87d13epbvn.fsf@cbaines.net> <87k1xji33m.fsf@gmail.com> Date: Tue, 27 Feb 2018 10:48:14 +0100 In-Reply-To: <87k1xji33m.fsf@gmail.com> (Chris Marusich's message of "Mon, 18 Dec 2017 23:33:33 -0800") Message-ID: <87h8q24vc1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 29732@debbugs.gnu.org Heya Chris, Looks like this patch is pretty much ready. Would you have time to take a look again? TIA, Ludo=E2=80=99. Chris Marusich skribis: > Christopher Baines writes: > >> I had a quick look at the patch, and it looks good to me. > > Thank you for taking a look! > >> A system test would be nice. I think the important thing to test is the >> Guix part of the service, so if it's possible to get it to start on a >> VM, I think just checking the status of the shepherd service would be a >> good test. > > OK. I'll find time to add something by the end of January.