From: ludo@gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 30711@debbugs.gnu.org
Subject: [bug#30711] [PATCH 1/1] guix: graph: Add Trival Graph Format (TGF) backend.
Date: Mon, 05 Mar 2018 18:17:04 +0100 [thread overview]
Message-ID: <87h8pu8msv.fsf@gnu.org> (raw)
In-Reply-To: <20180305114136.7207-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Mon, 5 Mar 2018 12:41:36 +0100")
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * guix/graph.scm ((emit-edge, emit-d3js-edge, emit-cypher-edge): New arguments
> label1 , label2.
> (emit-tg-progloug, mit-tgf-epilouge, emit-tgf-node, emit-tgf-edge): New
> variables.
> (%trivial-graph-backend): New variable.
> (%graph-backends): Add %trivial-graph-backend.
> (export-graph): Pass labels to emit-edge.
Can you tell us more about the Trivial Graph Format?
> -(define (emit-edge id1 id2 port)
> +(define (emit-edge id1 label1 id2 label2 port)
> (format port " \"~a\" -> \"~a\" [color = ~a];~%"
> id1 id2 (pop-color id1)))
This is orthogonal to adding a new format, so it should probably be a
separate patch.
> +(define (emit-tgf-edge id1 label1 id2 label2 port)
> + (format port "~a ~a~%" label1 label2))
This is probably incorrect because labels do not necessarily uniquely
identify nodes. This is why the API distinguishes node identifiers and
labels.
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-03-05 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 11:41 [bug#30711] [PATCH 1/1] guix: graph: Add Trival Graph Format (TGF) backend Hartmut Goebel
2018-03-05 17:17 ` Ludovic Courtès [this message]
2018-03-05 21:12 ` Hartmut Goebel
2018-03-06 10:32 ` Ludovic Courtès
2018-03-06 20:20 ` bug#30711: " Hartmut Goebel
2018-03-06 21:05 ` [bug#30711] " Björn Höfling
2018-03-06 21:23 ` Hartmut Goebel
2018-03-12 14:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8pu8msv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30711@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).