From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcoTF-00033H-Sx for guix-patches@gnu.org; Tue, 10 Jul 2018 04:58:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcoTC-0003vj-MB for guix-patches@gnu.org; Tue, 10 Jul 2018 04:58:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcoTC-0003vU-Id for guix-patches@gnu.org; Tue, 10 Jul 2018 04:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fcoTC-0003cH-5a for guix-patches@gnu.org; Tue, 10 Jul 2018 04:58:02 -0400 Subject: [bug#32102] [PATCH] utils: Fix wrap-program filename generation. Resent-Message-ID: References: <20180709013103.26091-1-arunisaac@systemreboot.net> <87k1q4j1zk.fsf@lassieur.org> <87r2kc8pm8.fsf@lassieur.org> From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: Date: Tue, 10 Jul 2018 10:57:44 +0200 Message-ID: <87h8l7ii2f.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: Mark H Weaver , 32102@debbugs.gnu.org Arun Isaac writes: >> should WRAP (from python-build-system.scm) wrap files that already >> have a wrapper? I think it shouldn't. > > I agree with your analysis. How about I send a patch modifying WRAP > (from python-build-system) to only wrap non-hidden files (files whose > name do not begin with a dot) in bin and sbin? That sounds good, but I'm not a Python expert, and I don't know if there are cases where hidden files would need to be wrapped. I'm CCing Andreas and Mark because they know better than me.