unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches <guix-patches@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 36814@debbugs.gnu.org
Subject: [bug#36814] [BONUS PATCH 3/2] gnu: intel-vaapi-driver: Provide LIBVA_DRIVERS_PATH.
Date: Sat, 27 Jul 2019 20:50:30 +0200	[thread overview]
Message-ID: <87h877gvm1.fsf@nckx> (raw)
In-Reply-To: <87a7cz49mf.fsf@devup.no>

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Marius Bakke 写道:
> Tobias Geerinckx-Rice via Guix-patches <guix-patches@gnu.org> 
> writes:
>
>> * gnu/packages/video.scm 
>> (intel-vaapi-driver)[native-search-paths]:
>> Export LIBVA_DRIVERS_PATH when installed.
>
> Can this be squashed into patch 1/2 in this series?

Sure.  I wasn't really going to merge this as FREE BONUS PATCH, 
don't worry.

>> (libva-without-mesa)[native-search-paths]: Don't inherit any.
>
> ..and this added in a separate patch, so that the 
> intel-vaapi-driver
> change does not have to go through 'staging'?

Are you sure?  This hunk is here to keep the mesa derivation 
unchanged.  Removing (or delaying) it *will* cause all of mesa's 
1436 dependents to be rebuilt.  I don't think we want that.

>> I'm leaving the enormocomment in so I don't have to repeat it 
>> here, but I'm less sure about it now than when I wrote it.  I 
>> thought this was a filthy hack, but maybe it's just mildly 
>> unconventional ;-)  The documentation is very sparse indeed.
>
> The comment could perhaps be shortened by including a link to
> <https://issues.guix.gnu.org/issue/22138>.

Oh thank gods yes.  I missed that bug.  I'm glad this is 
considered important.  For now, this workaround + a link seems 
acceptable to me.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2019-07-27 18:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26  3:27 [bug#36814] [PATCH 0/2] Add VA-API Intel back-end and utilities Tobias Geerinckx-Rice via Guix-patches
2019-07-26  3:30 ` [bug#36814] [PATCH 1/2] gnu: Add intel-vaapi-driver Tobias Geerinckx-Rice via Guix-patches
2019-07-26  3:30   ` [bug#36814] [PATCH 2/2] gnu: Add libva-utils Tobias Geerinckx-Rice via Guix-patches
2019-07-27 18:37     ` Marius Bakke
2019-07-27 18:35   ` [bug#36814] [PATCH 1/2] gnu: Add intel-vaapi-driver Marius Bakke
2019-07-27 19:00     ` Tobias Geerinckx-Rice via Guix-patches
2019-07-26  8:17 ` [bug#36814] [PATCH 0/2] Add VA-API Intel back-end and utilities Tobias Geerinckx-Rice via Guix-patches
2019-07-26  8:56   ` Jelle Licht
2019-07-26 17:58     ` Tobias Geerinckx-Rice via Guix-patches
2019-07-26 18:40 ` [bug#36814] [BONUS PATCH 3/2] gnu: intel-vaapi-driver: Provide LIBVA_DRIVERS_PATH Tobias Geerinckx-Rice via Guix-patches
2019-07-27 18:26   ` Marius Bakke
2019-07-27 18:50     ` Tobias Geerinckx-Rice via Guix-patches [this message]
2019-07-27 19:08       ` Tobias Geerinckx-Rice via Guix-patches
2019-07-27 19:16         ` Marius Bakke
2019-07-27 19:13       ` Marius Bakke
2019-07-27 21:29 ` bug#36814: [PATCH 0/2] Add VA-API Intel back-end and utilities Tobias Geerinckx-Rice via Guix-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h877gvm1.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=36814@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).