Pierre Neidhardt skribis:

> Hi Guillaume,
>
> thanks for the big patchset, looking very good overall!
>
> A few general nits:
>
> - You didn't define any "ecl-" package.  Could you define them for all the
>   packages (unless they are known to be broken with ECL)?
>   I know some packages lack the ecl- definition, this should be fixed :p
>
> - 6 commit messages lack a period on the first line.
>   If you use Emacs, you might find this yasnippet useful:
>   guix/etc/snippets/text-mode/guix-commit-message-add-package
>
> fprog:
>   - Description should start with a capital, or here maybe with @code{fprog}.
>
> cambl:
>   - is spelled in all-caps ("CAMBL") according to the README.
>
> cl-containers:
>   - synopsis: "Container library ..."
>
>   - I'm realizing the sbcl-lift does not have the right version number, which
>     should be (git-version "1.7.1" ...).  Can you update this?
>
> bst:
>   - 1.1 is out ;)
>
> cl-octet-streams:
>   - Description should start with a capital, or here maybe with @code{cl-octet-streams}.
>
> cl-lzlib
>   - License seems to be GPL-3, not GPL-3+, but since this is your library, the
>     decision is all yours ;)
>
> Thanks a lot for this great contribution to "Common Lisp on Guix" :)

Hi,

Here's the updated patch set (I think I didn't forget anything).

However some "ecl-" packages can't be built
right now because of a dependency that fails to build
(/gnu/store/sjyr2l309ldnfg9db718y585b3c13g51-ecl-hu.dwim.asdf-0.0.0-1.170b0e4.drv,
which apparently tries to load an SBCL-specific package).