From: "Ludovic Courtès" <ludo@gnu.org>
To: Hamzeh Nasajpour <h.nasajpour@pantherx.org>
Cc: 37535@debbugs.gnu.org
Subject: [bug#37535] [PATCH] gnu: Add python-flask-cors.
Date: Sat, 28 Sep 2019 22:40:50 +0200 [thread overview]
Message-ID: <87h84wnoh9.fsf@gnu.org> (raw)
In-Reply-To: <3f1fdf71-c664-4fb1-8ba1-f82e2d5f39b7@www.fastmail.com> (Hamzeh Nasajpour's message of "Sat, 28 Sep 2019 01:46:24 +0330")
Hi Hamzeh,
"Hamzeh Nasajpour" <h.nasajpour@pantherx.org> skribis:
> * gnu/packages/python-web.scm (python-flask-cors): New variable.
[...]
> +(define-public python-flask-cors
> + (package
> + (name "python-flask-cors")
> + (version "3.0.7")
The indentation is different from what we usually do. Could you run
./etc/indent-code.el as noted at
<https://guix.gnu.org/manual/en/html_node/Formatting-Code.html>?
> + (arguments
> + `(#:tests? #f))
Could you try to run the test suite or, as a last resort, add a comment
explaining why it is disabled?
> + (home-page "https://github.com/corydolphin/flask-cors")
> + (synopsis "A Flask extension adding a decorator for CORS support")
> + (description
> + "A Flask extension for handling Cross Origin Resource Sharing (CORS),
> +making cross-origin AJAX possible.")
Please fix the issue reported by ‘guix lint’ for the synopsis and make a
full sentence for the description. See
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-09-28 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 22:16 [bug#37535] [PATCH] gnu: Add python-flask-cors Hamzeh Nasajpour
2019-09-28 20:40 ` Ludovic Courtès [this message]
2019-10-06 12:36 ` Ludovic Courtès
2023-05-28 21:34 ` bug#37535: " Jelle Licht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h84wnoh9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37535@debbugs.gnu.org \
--cc=h.nasajpour@pantherx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).