From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZi1M-0004gk-0G for guix-patches@gnu.org; Tue, 26 Nov 2019 16:05:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZhvK-0001HL-MK for guix-patches@gnu.org; Tue, 26 Nov 2019 15:59:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZhvK-0001H8-J2 for guix-patches@gnu.org; Tue, 26 Nov 2019 15:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZhvK-0004fs-Ir for guix-patches@gnu.org; Tue, 26 Nov 2019 15:59:02 -0500 Subject: [bug#38325] [PATCH 1/2] gnu: Add tdlib. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87mucnviyy.fsf@posteo.net> <87v9r67vxn.fsf@gnu.org> <87r21u4emd.fsf@posteo.net> Date: Tue, 26 Nov 2019 21:58:30 +0100 In-Reply-To: <87r21u4emd.fsf@posteo.net> (Brett Gilio's message of "Tue, 26 Nov 2019 13:33:14 -0600") Message-ID: <87h82qz761.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brett Gilio Cc: 38325@debbugs.gnu.org Hello, Brett Gilio skribis: > I have fixed the linting issue. The reason why I have disabled tests is > because the test cases require internet connection. > > [ 1][t 0][1574796396.378631592][mtproto.cpp:64][!GetHostByNameActor] 7 "w= eb.telegram.org" [Error : 0 : Failed to resolve host: Name or service not k= nown] > [ 1][t 0][1574796396.378687382][mtproto.cpp:64][!GetHostByNameActor] 8 "w= eb.telegram.org" [Error : 0 : Failed to resolve host: Name or service not k= nown] > [ 1][t 0][1574796396.378721476][mtproto.cpp:64][!GetHostByNameActor] 9 "w= eb.telegram.org." [Error : 0 : Failed to resolve host: Name or service not = known] > [ 1][t 0][1574796396.378756762][mtproto.cpp:64][!GetHostByNameActor] 10 "= web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not= known] > [ 1][t 0][1574796396.378843307][mtproto.cpp:64][!GetHostByNameActor] 11 "= =D0=BC=D0=BE=D1=81=D0=BA=D0=B2=D0=B0.=D1=80=D1=84" [Error : 0 : Failed to r= esolve host: Name or service not known] > [ 1][t 0][1574796396.379258633][mtproto.cpp:64][!GetHostByNameActor] 37 "= web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not = known] > [ 1][t 0][1574796396.379312277][mtproto.cpp:64][!GetHostByNameActor] 38 "= web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not = known] > [ 1][t 0][1574796396.379376888][mtproto.cpp:64][!GetHostByNameActor] 39 "= web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not= known] > [ 1][t 0][1574796396.379430532][mtproto.cpp:64][!GetHostByNameActor] 40 "= web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not= known] > [ 1][t 0][1574796396.379479170][mtproto.cpp:64][!GetHostByNameActor] 41 "= =D0=BC=D0=BE=D1=81=D0=BA=D0=B2=D0=B0.=D1=80=D1=84" [Error : 0 : Failed to r= esolve host: Name or service not known] > [ 1][t 0][1574796396.381045103][mtproto.cpp:64][!GetHostByNameActor] 67 "= web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not = known] > [ 1][t 0][1574796396.381077766][mtproto.cpp:64][!GetHostByNameActor] 68 "= web.telegram.org" [Error : 0 : Failed to resolve host: Name or service not = known] > [ 1][t 0][1574796396.381108761][mtproto.cpp:64][!GetHostByNameActor] 69 "= web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not= known] > [ 1][t 0][1574796396.381140471][mtproto.cpp:64][!GetHostByNameActor] 70 "= web.telegram.org." [Error : 0 : Failed to resolve host: Name or service not= known] > [ 1][t 0][1574796396.381173134][mtproto.cpp:64][!GetHostByNameActor] 71 "= =D0=BC=D0=BE=D1=81=D0=BA=D0=B2=D0=B0.=D1=80=D1=84" [Error : 0 : Failed to r= esolve host: Name or service not known] > > I might be able to strip out those particular tests, but it would seem > to me that needing internet connection on a test case is likely not the > "Guix way" of doing this. Right, there=E2=80=99s no network access in the build environment. So those tests that rely on being able to talk to telegram.org & co. must be skipped. If possible, it=E2=80=99s best to skip only those and still run tests that don=E2=80=99t depend on network access. If we have to #:tests? #f altogether, then please add a comment explaining why we=E2=80=99re doing this, for our future selves. :-) Thanks in advance! Ludo=E2=80=99.