From: "Ludovic Courtès" <ludo@gnu.org>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 38630@debbugs.gnu.org
Subject: [bug#38630] Software Heritage (swh): Fix API change, causing repeatedly submitting archives
Date: Tue, 17 Dec 2019 17:41:04 +0100 [thread overview]
Message-ID: <87h81yrjkv.fsf@gnu.org> (raw)
In-Reply-To: <20191215223433.5ce5be20@alma-ubu> ("Björn Höfling"'s message of "Sun, 15 Dec 2019 22:34:33 +0100")
Hello!
Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:
> when linting, I recognized that the archival linter was repeatedly
> sending packages to the SWH, despite that the package was already
> archived.
>
> With some investigations, I noticed they changed the API. Here's a
> patch that fixes it.
Good catch!
> I have not communicated with SWH about that, especially I have not asked
> SWH why they broke the API without updating the version number.
Yeah, that’s weird, I’ve pinged them on IRC.
It seems that the removal was intentional as part of
<https://forge.softwareheritage.org/D2167>, but it wasn’t clear whether
the API breakage should have happened. This led them to open a new
task: <https://forge.softwareheritage.org/T2158>. We should keep an eye
on it.
> From a5ada85d168b45d517d8faf0d79ad5beccc26911 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
> <bjoern.hoefling@bjoernhoefling.de>
> Date: Sun, 15 Dec 2019 22:00:56 +0100
> Subject: [PATCH] swh: Fix API call for getting origin.
>
> When using the archival linter, git origins already in the archive where
> not recognized due to an API change and where repeatedly asked for archival.
> This is fixed here.
>
> * guix/swh.scm (lookup-origin): Fix API URI for getting origin.
> (<origin>): Fix comment with API URI example.
In the meantime, your patch looks like the right move, so you can push it.
Thank you!
Ludo’.
next prev parent reply other threads:[~2019-12-17 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 21:34 [bug#38630] Software Heritage (swh): Fix API change, causing repeatedly submitting archives Björn Höfling
2019-12-17 16:41 ` Ludovic Courtès [this message]
2019-12-17 22:32 ` bug#38630: " Björn Höfling
2019-12-18 9:22 ` [bug#38630] " Jonathan Brielmaier
2019-12-18 21:44 ` Björn Höfling
2019-12-20 0:48 ` Jonathan Brielmaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h81yrjkv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38630@debbugs.gnu.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).