From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 38513-done@debbugs.gnu.org
Subject: bug#38513: [PATCH] gnu: Remove uses of deprecated Qemu "-nic, model=foo" invokations.
Date: Wed, 18 Dec 2019 22:12:08 +0100 [thread overview]
Message-ID: <87h81xcp93.fsf@devup.no> (raw)
In-Reply-To: <87fthmwkmv.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> * gnu/build/vm.scm (load-in-linux-vm): Move Qemu network configuration from
>> ARCH-SPECIFIC-FLAGS to the Qemu command line. Use the "-nic" option of Qemu
>> instead of "-device" and "-net".
>> * gnu/system/vm.scm (common-qemu-options): Change "-net nic ..." to "-nic user ...".
>> * doc/guix.texi (Installing Guix in a VM, Running Guix in a VM): Adjust
>> examples accordingly.
>
> Apart from the typo Leo noted, it LGTM! :-)
I discovered a problem with our documentation when researching this
patch. Qemu nowadays, with no "-nic" or related arguments, acts the
same as "-nic,model=e1000e". So a full network is available by default,
unless one adds "-nic none".
The "Running Guix in a VM" section of the manual mentions Qemu
networking twice, and both are inaccurate or wrong. It would be good to
reword that section. Any takers? :-)
In any case this patch will be pushed shortly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 483 bytes --]
prev parent reply other threads:[~2019-12-18 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 21:13 [bug#38513] [PATCH] gnu: Remove uses of deprecated Qemu "-nic, model=foo" invokations Marius Bakke
2019-12-07 17:52 ` Leo Famulari
2019-12-14 23:30 ` Ludovic Courtès
2019-12-18 21:12 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h81xcp93.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=38513-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).