From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 39086@debbugs.gnu.org
Subject: [bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support.
Date: Thu, 16 Jan 2020 22:10:37 +0100 [thread overview]
Message-ID: <87h80vxg36.fsf@elephly.net> (raw)
In-Reply-To: <20200111120829.29821-4-leo.prikler@student.tugraz.at>
Leo Prikler <leo.prikler@student.tugraz.at> writes:
> * gnu/packages/ibus.scm (ibus) [inputs]: Add unicode-emoji and
> unicode-cldr-common.
> [configure-flags]: Add flags for emoji and annotations.
This should be “arguments”, not “configure-flags”. Also: please remove
the space between “(ibus)” and “[inputs]”.
> (arguments
> `(#:tests? #f ; tests fail because there's no connection to dbus
> - #:configure-flags `("--disable-emoji-dict" ; cannot find emoji.json path
> - "--enable-python-library"
> + #:configure-flags `("--enable-python-library"
> + ,(string-append
> + "--with-unicode-emoji-dir="
> + (assoc-ref %build-inputs "unicode-emoji")
> + "/share/unicode/emoji")
> + ,(string-append
> + "--with-emoji-annotation-dir="
> + (assoc-ref %build-inputs "unicode-cldr-common")
> + "/share/unicode/cldr/common/annotations")
> ,(string-append "--with-ucd-dir="
> (getcwd) "/ucd")
> "--enable-wayland")
Now that the configure flags are so long I have a preference for
dropping quoting and using (list …) instead. All that unquoting looks a
little too noisy.
> @@ -241,6 +248,8 @@ conventions.")
> `(("glib" ,glib "bin") ; for glib-genmarshal
> ("gobject-introspection" ,gobject-introspection) ; for g-ir-compiler
>
> + ("unicode-emoji" ,unicode-emoji)
> + ("unicode-cldr-common" ,unicode-cldr-common)
> ;; XXX TODO: Move Unicode data to its own (versioned) package.
> ("unicode-nameslist"
> ,(origin
Oh, here is the comment I mentioned earlier!
--
Ricardo
next prev parent reply other threads:[~2020-01-16 21:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 11:58 [bug#39086] [PATCH] Enable Emoji support in IBus Leo Prikler
2020-01-11 12:08 ` [bug#39086] [PATCH 1/5] licenses: Add Unicode license Leo Prikler
2020-01-11 12:08 ` [bug#39086] [PATCH 2/5] gnu: Add unicode-emoji Leo Prikler
2020-01-16 21:04 ` Ricardo Wurmus
2020-01-16 22:49 ` Leo Prikler
2020-01-11 12:08 ` [bug#39086] [PATCH 3/5] gnu: Add unicode-cldr-common Leo Prikler
2020-01-16 21:08 ` Ricardo Wurmus
2020-01-16 22:53 ` Leo Prikler
2020-01-17 7:41 ` Ricardo Wurmus
2020-01-17 10:41 ` Leo Prikler
2020-02-03 9:49 ` Leo Prikler
2020-02-03 15:33 ` bug#39086: " Ricardo Wurmus
2020-02-03 15:46 ` [bug#39086] " Leo Prikler
2020-02-03 16:06 ` Ricardo Wurmus
2020-01-11 12:08 ` [bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support Leo Prikler
2020-01-16 21:10 ` Ricardo Wurmus [this message]
2020-01-11 12:08 ` [bug#39086] [PATCH 5/5] gnu: ibus: Disable parallel build Leo Prikler
2020-01-16 21:13 ` Ricardo Wurmus
2020-01-17 0:19 ` [bug#39086] [PATCH 2/5] gnu: Add unicode-emoji Leo Prikler
2020-01-17 0:19 ` [bug#39086] [PATCH 3/5] gnu: Add unicode-cldr-common Leo Prikler
2020-01-17 0:19 ` [bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support Leo Prikler
2020-01-17 0:19 ` [bug#39086] [PATCH 5/5] gnu: ibus: Disable parallel build Leo Prikler
2020-01-17 1:17 ` [bug#39086] [PATCH 2/5] gnu: Add unicode-emoji Leo Prikler
2020-01-17 10:37 ` Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h80vxg36.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=39086@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).