From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56747) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0YWB-0002MZ-Nb for guix-patches@gnu.org; Sat, 08 Feb 2020 17:24:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0YWA-0007a1-Kp for guix-patches@gnu.org; Sat, 08 Feb 2020 17:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0YWA-0007Zq-CM for guix-patches@gnu.org; Sat, 08 Feb 2020 17:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0YWA-0002P9-8D for guix-patches@gnu.org; Sat, 08 Feb 2020 17:24:02 -0500 Subject: [bug#39384] [PATCH] gnu: Add emacs-rg. Resent-Message-ID: References: <87v9oqrr0q.fsf@lafreniere.xyz> <878slmc640.fsf@nicolasgoaziou.fr> <87pnexrrwf.fsf@lafreniere.xyz> <20200202184757.GH9517@E5400> <87o8ugs5fu.fsf@lafreniere.xyz> <20200204095851.GA19864@E5400> <87mu9xspd0.fsf@lafreniere.xyz> <87lfpg4t3t.fsf@devup.no> <87lfpfrzok.fsf@lafreniere.xyz> <20200207105435.GG7827@E5400> From: "LaFreniere\, Joseph" Message-ID: <87h800soqr.fsf@lafreniere.xyz> In-reply-to: <20200207105435.GG7827@E5400> Date: Sat, 08 Feb 2020 16:23:08 -0600 MIME-Version: 1.0 Content-Type: text/plain; format=flowed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 39384@debbugs.gnu.org, Marius Bakke , Nicolas Goaziou Efraim Flashner writes: > On Thu, Feb 06, 2020 at 06:47:23PM -0600, LaFreniere, Joseph > wrote: >> >> Marius Bakke writes: >> > "LaFreniere\, Joseph" writes: >> > > Ah, I see what you mean now. But wouldn't hard-coding the >> > > path to >> > > ripgrep in that way prevent the package from being able to >> > > use >> > > remote systems' ripgrep binaries when running over TRAMP? >> > >> > Perhaps we could patch [emacs-rg] to do both? Use the store >> > prefix if >> > it >> > exists, and fall back to searching in PATH? >> >> What would be the advantage of that over just searching PATH to >> start with? > > It will still work even if you don't have ripgrep specifically > installed. Can you point me to the Guix documentation where the functionality you're describing is explained? I have read through the description of package inputs in section 6.2.1 of Guix's manual, but I still do not explain what advantage patching the search path offers. My understanding is that if we want to preserve both local and remote-via-TRAMP functionality, we can either - just include ripgrep as a propagated input, or - include ripgrep as a propagated input _and_ patch the package to look for ripgrep in a hardcoded location (for local) as well as PATH (for TRAMP). Both options would have ripgrep included as propagated input. As soon as ripgrep is installed in a user's profile, its binary will be available on PATH. If that is correct, then I don't see any advantage to patching in a hardcoded path to ripgrep. -- Joseph LaFreniere