unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: iyzsong@member.fsf.org (宋文武)
To: Ekaitz Zarraga <ekaitz@elenq.tech>
Cc: "41294@debbugs.gnu.org" <41294@debbugs.gnu.org>
Subject: [bug#41294] [PATCH] gnu: Add libfreenect.
Date: Wed, 20 May 2020 21:33:08 +0800	[thread overview]
Message-ID: <87h7wak9yj.fsf@member.fsf.org> (raw)
In-Reply-To: <9ZfB8rv2oVS3f1P4KqZV9twP9VRoO9GNuPvbzT_BjLAzXCs6kumdqaIPD_TMejSv5B0D34dg6tpbmKPmIQxuLW64pU35VX5LGNn5tM9Ka04=@elenq.tech> (Ekaitz Zarraga's message of "Tue, 19 May 2020 13:52:15 +0000")

Ekaitz Zarraga <ekaitz@elenq.tech> writes:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Tuesday, May 19, 2020 3:42 PM, Ekaitz Zarraga <ekaitz@elenq.tech> wrote:
>
>> Hi,
>>
>> > > There's some kind of weird magic I'm not getting.
>> >
>> > Hello, I don't know the whole detail too, but to build a package, guix likely:
>> >
>> > -   Load and eval the package module, to get the package object. The
>> >     'arguments' field is a list.
>> >
>> > -   Convert this package object to a derivation, and write it in store as
>> >     a file (/gnu/store/*.drv). Where 'arguments' being part of the
>> >     builder, serialize as string to the file, it dosen't do complex things
>> >     for procedure bindings, only write their string descriptions... So
>> >     when the builder file is loaded, you get `Unknown object` errors.
>> >     Here, to avoid duplicating the code, you can:
>> >
>> >
>> > 1.  Unquote list value into `arguments`. (eg: 'asdf-substitutions' in lisp.scm)
>>
>> This doesn't work for me. I don't know why.
>>
>> Just moved the lambda to a (define* deactivate-sources ...) and then when I try to put the name like
>>
>> (arguments `( #tests? .... ,deactivate-sources ...)
>>
>> Shoots an Unknown object error. I add a diff below to let you see the whole picture of what I did and doesn't work.
>>
>> > 2.  Use `(package-arguments libfreenect-examples)` with
>> >     `substitute-keyword-arguments` to reuse arguments, but modify
>> >     `configure-flags` etc. (eg: qtx11extras)
>> >     The build system can use 'imported-modules' to make a set of guile
>> >     modules (which can contains useful procedures, etc.) available to the
>> >     builder, but thas's overkill to be used here...
>> >
>> [...]
>
> oh,
>
> the code is wrong, there parenthesis on the define are making it a function but anyway:
> - Tested using ,(disable-sources) FAIL
> - Tested removing the parenthesis and leaving (define disable-sources (lambda*...))
>
> There must be something I'm missing.

Um, I mean something like this:

  (define libfreenect-derived-phases
    '(modify-phases %standard-phases
       (lambda* (#:key outputs #:allow-other-keys)
         ...)))

  ...
  (arguments
   `(#:phases ,libfreenect-derived-phases))
  ...


Here 'libfreenect-derived-phases' is a list of symbols, the arguments
field we want is a list of symbols too.




  reply	other threads:[~2020-05-20 13:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 21:47 [bug#41294] [PATCH] gnu: Add libfreenect Ekaitz Zarraga
2020-05-15 23:09 ` [bug#41294] [PATCH] gnu: libfreenect: Correct native-inputs vs inputs Ekaitz Zarraga
2020-05-16  3:48 ` [bug#41294] [PATCH] gnu: Add libfreenect 宋文武
2020-05-16 10:18   ` Ekaitz Zarraga
2020-05-16 13:06     ` Ekaitz Zarraga
2020-05-16 13:28       ` Ekaitz Zarraga
2020-05-17  2:15       ` 宋文武
2020-05-17  9:37         ` Ekaitz Zarraga
2020-05-17 12:15           ` Ekaitz Zarraga
2020-05-19 13:26             ` 宋文武
2020-05-19 13:42               ` Ekaitz Zarraga
2020-05-19 13:52                 ` Ekaitz Zarraga
2020-05-20 13:33                   ` 宋文武 [this message]
2020-05-20 16:37                     ` Ekaitz Zarraga
2020-05-21 11:38                       ` bug#41294: " 宋文武
2020-05-21 11:40                         ` [bug#41294] " Ekaitz Zarraga
2020-05-17  1:56     ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7wak9yj.fsf@member.fsf.org \
    --to=iyzsong@member.fsf.org \
    --cc=41294@debbugs.gnu.org \
    --cc=ekaitz@elenq.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).