From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2GrKC3XF2F4abgAA0tVLHw (envelope-from ) for ; Thu, 04 Jun 2020 09:57:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oCSOB3XF2F7pdAAAB5/wlQ (envelope-from ) for ; Thu, 04 Jun 2020 09:57:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA8D59401AE for ; Thu, 4 Jun 2020 09:57:08 +0000 (UTC) Received: from localhost ([::1]:39788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgmcV-0005od-DK for larch@yhetil.org; Thu, 04 Jun 2020 05:57:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgmcQ-0005oS-Dd for guix-patches@gnu.org; Thu, 04 Jun 2020 05:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgmcQ-0007CB-46 for guix-patches@gnu.org; Thu, 04 Jun 2020 05:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgmcQ-0004HA-39 for guix-patches@gnu.org; Thu, 04 Jun 2020 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH v3 1/9] gnu: java-openjfx-build: Add helpful patch. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jun 2020 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Cc: 41360@debbugs.gnu.org, Julien Lepiller Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.159126456916371 (code B ref 41360); Thu, 04 Jun 2020 09:57:02 +0000 Received: (at 41360) by debbugs.gnu.org; 4 Jun 2020 09:56:09 +0000 Received: from localhost ([127.0.0.1]:45176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgmbZ-0004Fz-1t for submit@debbugs.gnu.org; Thu, 04 Jun 2020 05:56:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgmbX-0004Fl-Ci for 41360@debbugs.gnu.org; Thu, 04 Jun 2020 05:56:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57656) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgmbR-0006eZ-Aj; Thu, 04 Jun 2020 05:56:01 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44758 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jgmbQ-0003zS-Ta; Thu, 04 Jun 2020 05:56:01 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200517132829.1553311-1-levenson@mmer.org> <20200530170951.1649-1-levenson@mmer.org> <87pnagkv1t.fsf@gnu.org> <0F005145-C408-4B05-86C2-750219F7F2E3@lepiller.eu> <877dwoyulp.fsf@mmer.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 Prairial an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 04 Jun 2020 11:55:59 +0200 In-Reply-To: <877dwoyulp.fsf@mmer.org> (Alexey Abramov's message of "Wed, 03 Jun 2020 18:36:34 +0200") Message-ID: <87h7vrduj4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: NS2TYctWhfe8 Hi, Alexey Abramov skribis: > Julien Lepiller writes: > >> Le 3 juin 2020 11:50:38 GMT-04:00, "Ludovic Court=C3=A8s" = a =C3=A9crit : >>>Alexey Abramov skribis: >>> >>>> +++ b/gnu/packages/patches/java-openjfx-build-jdk_version.patch >> >>>> @@ -0,0 +1,27 @@ >>>> +Subject: [PATCH] openjfx: Determine the version of Java in JDK_HOME >>>> + >>>> +Icedtea contains guix in its version, so build.gradle failes to run. >>>Openjfx >>>> +packaging is not trivial, so you will probably need to try build it >>>with >>>> +gradlew. >>>> + >>>> +--- >>>> + build.gradle | 5 ++--- >>>> + 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>>This patch also made me realize that we=E2=80=99re using Gradle here, but >>>there=E2=80=99s no Gradle package in Guix. That means we must be using a >>>pre-built jar somewhere, though I didn=E2=80=99t find it. Any idea wher= e that >>>comes from? Julien, any idea? >>> >>>(The problem existed before your patches.) >>> >>>Thanks, >>>Ludo=E2=80=99. >> >> From what I understand, this patcg helps build openjfx with gradle on >> guix, if you use the guix source in an environment, but reading the >> other patches, it doesn't look like gradle is actually used anywhere. >> >> It looks like this patch is helpful in the sense that it allows users to= manually build the package outside of guix, but is not used at all during = the build of openjfx by guix itself. >> >> Alexey, can you confirm? > > Yes, you are right. I am not using gradle. The reason for this patch was > to be able to debug the building process openjfx. I had to run gradlew > multiple times, so I decided to just patch it. OK, thanks for explaining! BTW, I=E2=80=99ve pushed the first two patches of this series, Alexey. Ludo=E2=80=99.