From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eBptMn0F+l7bBQAA0tVLHw (envelope-from ) for ; Mon, 29 Jun 2020 15:15:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KHkrLn0F+l5PKQAAbx9fmQ (envelope-from ) for ; Mon, 29 Jun 2020 15:15:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 498C99401CB for ; Mon, 29 Jun 2020 15:15:09 +0000 (UTC) Received: from localhost ([::1]:43154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpvUx-0001f7-Cp for larch@yhetil.org; Mon, 29 Jun 2020 11:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpvUt-0001em-Go for guix-patches@gnu.org; Mon, 29 Jun 2020 11:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpvUt-0008TZ-6e for guix-patches@gnu.org; Mon, 29 Jun 2020 11:15:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpvUt-0007MI-2v for guix-patches@gnu.org; Mon, 29 Jun 2020 11:15:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Jun 2020 15:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42030 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 42030@debbugs.gnu.org Received: via spool by 42030-submit@debbugs.gnu.org id=B42030.159344369228232 (code B ref 42030); Mon, 29 Jun 2020 15:15:03 +0000 Received: (at 42030) by debbugs.gnu.org; 29 Jun 2020 15:14:52 +0000 Received: from localhost ([127.0.0.1]:49094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpvUi-0007LI-89 for submit@debbugs.gnu.org; Mon, 29 Jun 2020 11:14:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpvUf-0007L1-Ti for 42030@debbugs.gnu.org; Mon, 29 Jun 2020 11:14:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33102) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpvUa-0008Q2-I8 for 42030@debbugs.gnu.org; Mon, 29 Jun 2020 11:14:44 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38888 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpvUZ-0006Zb-Mh; Mon, 29 Jun 2020 11:14:43 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200624125749.10908-1-ludo@gnu.org> <87d05o6ubc.fsf@gnu.org> <87r1u3trx8.fsf@gnu.org> <87o8p2ayaj.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 29 Jun 2020 17:14:40 +0200 In-Reply-To: <87o8p2ayaj.fsf@gnu.org> (Marius Bakke's message of "Mon, 29 Jun 2020 13:47:48 +0200") Message-ID: <87h7utc3a7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: cdPuUZEHq8Wh Hi! Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >>> I think we should export %guix-channel-introduction, or alternatively >>> add a %default-guix-channel that can be inherited, for easy access in >>> custom channels.scm files. WDYT? >> >> The idea was to expose only =E2=80=98%default-channels=E2=80=99, which l= eaves room for >> the possibility of having multiple channels by default. I=E2=80=99d rat= her >> avoid exposing the individual bits as that=E2=80=99s a bit of an additio= nal >> committment. >> >> But note that the introduction of the =E2=80=9Cofficial=E2=80=9D guix ch= annel is >> automatically added anyway (commit >> c3f6f564e909ebefe752d24b325871a4e3a02d40). > > It is only added for people using the default channel URL, and not for > local mirrors that may well be authenticated. E.g. (url "/some/dir") or > (url "https://github.com/guix-mirror/guix"). > > Would it make sense to remove the %default-channel-url check from > ensure-default-introductions? I think we can safely assume that a > channel named 'guix is _the_ Guix channel regardless of where it came > from, and if users need to override the introduction they can just do > that. I don=E2=80=99t think we can do that: if someone who=E2=80=99s not currentl= y a committer wants to publish a fork, they=E2=80=99ll also publish a different introduct= ion, pointing to the first commit where they=E2=80=99re in =E2=80=98.guix-author= izations=E2=80=99. > Currently I do this to access the channel introduction, which seems > needlessly complicated: > > (use-modules (srfi srfi-1)) > (let ((guix-channel (find (lambda (channel) > (eq? 'guix (channel-name channel))) > %default-channels))) You can write: (find guix-channel? %default-channels). > (list [other channels omitted] > (channel > (inherit guix-channel) > (url "/home/marius/src/guix")))) I=E2=80=99m hesitant. We can publish =E2=80=98%guix-channel-introduction= =E2=80=99 if it helps, but it=E2=80=99s a slight maintenance constraint for a slight improvement. = :-) WDYT? Ludo=E2=80=99.