From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MJ7XHd24BF9BQgAA0tVLHw (envelope-from ) for ; Tue, 07 Jul 2020 18:03:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CEi5Gd24BF9aGAAAB5/wlQ (envelope-from ) for ; Tue, 07 Jul 2020 18:03:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC8D8940ACE for ; Tue, 7 Jul 2020 18:03:08 +0000 (UTC) Received: from localhost ([::1]:34454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsrvu-00056a-Pi for larch@yhetil.org; Tue, 07 Jul 2020 14:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsrvq-00056S-S4 for guix-patches@gnu.org; Tue, 07 Jul 2020 14:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsrvq-0000pM-JJ for guix-patches@gnu.org; Tue, 07 Jul 2020 14:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsrvq-00046P-Gm for guix-patches@gnu.org; Tue, 07 Jul 2020 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42249] [PATCH] gnu: Add font-libertinus. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Jul 2020 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tim Van den Langenbergh Cc: 42249@debbugs.gnu.org Received: via spool by 42249-submit@debbugs.gnu.org id=B42249.159414493815713 (code B ref 42249); Tue, 07 Jul 2020 18:03:02 +0000 Received: (at 42249) by debbugs.gnu.org; 7 Jul 2020 18:02:18 +0000 Received: from localhost ([127.0.0.1]:36683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsrv8-00045N-0w for submit@debbugs.gnu.org; Tue, 07 Jul 2020 14:02:18 -0400 Received: from tobias.gr ([80.241.217.52]:41980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsrv5-00045D-Hs for 42249@debbugs.gnu.org; Tue, 07 Jul 2020 14:02:17 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id adce097e; Tue, 7 Jul 2020 18:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=1/T+hnrLArHsGqse4q7ah5 DTxV6oeYpSyk0m9D/l7hQ=; b=DL73+T5VeX21e5XiiPxlAlP8FUnyprkUJ9Cwoc loXUlvkY5AFe+NCQDG44K7iiRk7aJiZudxCzsBDDQ2BrraoFWy9xNIwU+uTCR6m4 D0KD1VhNH8RiJ+wcnkDikaiAh51TxHe3XJKd4ytfQfRZiP7wcpIY29qno/VYBVOw fXakBn/Eqpi3j+3IrSaYHAu2AN/XNHltdEC0g7KPdhD2e3JF5BsPPgJfX8n+NzAC KpqEhAXU1ed19hM+fl2+/sWwfM9APm1Z7u1aZJbVPgiYSNNUC6p0kjZusoWUw6U7 wc4BiO3rtvpfHPMxeJn7cPlFQOLkHiDtmfVTGRoR6WOLPS1w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id c4d99ed7 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 7 Jul 2020 18:02:21 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: In-reply-to: Date: Tue, 07 Jul 2020 20:02:13 +0200 Message-ID: <87h7ujryoq.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tobias.gr header.s=2018 header.b=DL73+T5V; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: Io9R2NKsQgaq --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tim, Tim Van den Langenbergh =E5=86=99=E9=81=93=EF=BC=9A > I am rather fond of the Libertinus Mono font for Emacs, as I=20 > like my Monospace fonts to have Serifs. Interesting=E2=80=A6 > As others may like the font as well I have created a patch to=20 > add it to the fonts package. Thank you! > This being the first patch I have ever submitted to Guix I'm not=20 > entirely sure I did everything right, I followed the Submitting=20 > Patches part of the manual as close as I could, but I may have=20 > made a mistake somewhere, so feel free to correct me where=20 > needed. Your first commit message is flawless; congratulations! :-) However, [how] did you install and test this package? This: + (source (origin + (method git-fetch) + (uri (string-append=20 "https://github.com/alerque/libertinus/" + "commit/" +=20 "800155085d4a1592dc6e76b34cd625794cd0fcdf")) + (sha256 + (base32=20 "1mj0d84k1x15hsgksca0qjhc3mmzyaqaqa2vyrbb6s96ycsfsgq3")))) isn't a valid GIT-FETCH origin: =2D-8<---------------cut here---------------start------------->8--- ~/guix master =CE=BB guix build font-libertinus Backtrace: In ice-9/boot-9.scm: 1736:10 4 (with-exception-handler _ _ #:unwind? _=20 #:unwind-for-type _) In unknown file: 3 (apply-smob/0 #) In ice-9/boot-9.scm: 718:2 2 (call-with-prompt _ _ #) In ice-9/eval.scm: 619:8 1 (_ #(#(#))) In guix/ui.scm: 1953:12 0 (run-guix-command _ . _) guix/ui.scm:1953:12: In procedure run-guix-command: In procedure struct-vtable: Wrong type argument in position 1=20 (expecting struct):=20 "https://github.com/alerque/libertinus/commit/800155085d4a1592dc6e76b34cd62= 5794cd0fcdf" =2D-8<---------------cut here---------------end--------------->8--- I replaced it with: + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/alerque/libertinus") + (commit (string-append "v" version)))) + (sha256 + (base32=20 "0flj3xwj8x938wh614ch295j040ccnha1nzmlg5sgpsyxg5gjsbf")))) Note the =E2=80=98commit=E2=80=99 that isn't. If you're lucky (which is most of the time), upstream will tag=20 releases & you won't need to hard-code the commit. This makes=20 updating the package later much easier. I don't know GitHub well enough to link to it directly, but you=20 can find a list of tags under the top-left =E2=80=98Branch: main=E2=80=99=20 drop-down here[0]. Now I get an encoding error which is probably not your =E2=80=98fault=E2=80= =99=E2=80=A6=20 Guile can be picky when it comes to locales. I'll poke at it some=20 more. Kind regards, T G-R [0]: https://github.com/alerque/libertinus --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXwS4pQAKCRANsP+IT1Vt eezSAP9cgliUfdnwj+kJFMM+iW2H/6Ujs7iyDihDNzVp8Xr6dgD/ZKMGQ0EsM94u 5iGymG42OWAkktoBvmXugp31o68zqAU= =Cmjo -----END PGP SIGNATURE----- --=-=-=--