From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0S1fL7VYMl9ZJAAA0tVLHw (envelope-from ) for ; Tue, 11 Aug 2020 08:37:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +E2QKbVYMl+RbAAA1q6Kng (envelope-from ) for ; Tue, 11 Aug 2020 08:37:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B27519402CC for ; Tue, 11 Aug 2020 08:37:08 +0000 (UTC) Received: from localhost ([::1]:52824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5PmM-0002j2-F9 for larch@yhetil.org; Tue, 11 Aug 2020 04:37:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5PmI-0002iv-HJ for guix-patches@gnu.org; Tue, 11 Aug 2020 04:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5PmI-0002aV-6u for guix-patches@gnu.org; Tue, 11 Aug 2020 04:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5PmH-0001s6-St for guix-patches@gnu.org; Tue, 11 Aug 2020 04:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42792] [PATCH] gnu: Add python-pydantic. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Aug 2020 08:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42792 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy Le Carrour Cc: 42792-done@debbugs.gnu.org Received: via spool by 42792-done@debbugs.gnu.org id=D42792.15971349657129 (code D ref 42792); Tue, 11 Aug 2020 08:37:01 +0000 Received: (at 42792-done) by debbugs.gnu.org; 11 Aug 2020 08:36:05 +0000 Received: from localhost ([127.0.0.1]:38533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5PlN-0001qv-7W for submit@debbugs.gnu.org; Tue, 11 Aug 2020 04:36:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5PlJ-0001qM-Hi for 42792-done@debbugs.gnu.org; Tue, 11 Aug 2020 04:36:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39081) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5PlD-0002Uv-8t; Tue, 11 Aug 2020 04:35:55 -0400 Received: from [2a01:e0a:19b:d9a0:3107:b202:556:bd51] (port=54722 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5PlB-0008UP-TN; Tue, 11 Aug 2020 04:35:54 -0400 From: Mathieu Othacehe References: <20200810084343.10734-1-tanguy@bioneland.org> <87wo26g6ji.fsf@gnu.org> <20200810141911.jtpjdeylftxiyk6q@rafflesia> Date: Tue, 11 Aug 2020 10:35:52 +0200 In-Reply-To: <20200810141911.jtpjdeylftxiyk6q@rafflesia> (Tanguy Le Carrour's message of "Mon, 10 Aug 2020 16:19:11 +0200") Message-ID: <87h7t9y3yv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: JuU2gFtpbvrp Hey Tanguy, >> (uri (git-reference >> (url "https://github.com/samuelcolvin/pydantic") >> - (commit (string-append "v" version)))) >> + (commit (string-append "v" version)))) >> (file-name (git-file-name name version)) >> - (sha256 (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws= 2z3j8")))) >> + (sha256 >> + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8")= ))) > > Thanks for paying attention to every details!! > Actually, those things have been bothering me for quiet a while=E2=80=A6 > They are not reported by `./pre-inst-env guix lint python-pydantic` or > fixed by `emacs --script etc/indent-code.el gnu/packages/python-xyz.scm p= ython-pydantic`. :-( The first diff is fixed when running "./etc/indent-code.el gnu/packages/python-xyz.scm python-pydantic" for me. > > Would the following have been acceptable? > > ``` >> + (sha256 (base32 >> + "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8")= ))) > ``` It is acceptable but the convention is to put "base32" on the next line. > > And what about this? (2-space indent instead of 1, like `add-before` belo= w) > > ``` >> + (sha256 >> + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"= )))) > ``` No only one space here, this is also handled by the indent script for me. > > >> (build-system python-build-system) >> (arguments >> '(#:phases >> (modify-phases %standard-phases >> - ;; Reported upstream: >> - ;; Not sure how to apply the suggested fix!? >> + ;; Reported upstream: >> + ;; . >> + ;; Disable the faulty test as the fix is unclear. > > Much better, thanks! > In retrospect, I realize that I should have put the question in the > commit message for a maintainer to read, not in the package definition. > Would that have been better?! No it's perfectly fine in the package declaration :) Hope I'm not bothering you to much with this boring syntactic stuff :p Thanks, Mathieu