From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wDeVBBT9TF/HQAAA0tVLHw (envelope-from ) for ; Mon, 31 Aug 2020 13:37:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SNdsABT9TF8oBwAA1q6Kng (envelope-from ) for ; Mon, 31 Aug 2020 13:37:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A468A940223 for ; Mon, 31 Aug 2020 13:37:23 +0000 (UTC) Received: from localhost ([::1]:60208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjzu-00028x-Hk for larch@yhetil.org; Mon, 31 Aug 2020 09:37:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCjza-0001de-H8 for guix-patches@gnu.org; Mon, 31 Aug 2020 09:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCjza-0002IW-7a for guix-patches@gnu.org; Mon, 31 Aug 2020 09:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCjza-0006ve-4V for guix-patches@gnu.org; Mon, 31 Aug 2020 09:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42849] [PATCH 2/3] linux-container: Add a jail? argument. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Aug 2020 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42849 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42849@debbugs.gnu.org Received: via spool by 42849-submit@debbugs.gnu.org id=B42849.159888097526566 (code B ref 42849); Mon, 31 Aug 2020 13:37:02 +0000 Received: (at 42849) by debbugs.gnu.org; 31 Aug 2020 13:36:15 +0000 Received: from localhost ([127.0.0.1]:51843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjyp-0006uP-7b for submit@debbugs.gnu.org; Mon, 31 Aug 2020 09:36:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjyn-0006uA-Cc for 42849@debbugs.gnu.org; Mon, 31 Aug 2020 09:36:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56225) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjyi-0002CO-4L for 42849@debbugs.gnu.org; Mon, 31 Aug 2020 09:36:08 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCjyh-000686-6p; Mon, 31 Aug 2020 09:36:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200813123419.263639-1-othacehe@gnu.org> <20200813123419.263639-2-othacehe@gnu.org> <87sgc3hpvp.fsf@gnu.org> <87k0xfib4b.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 31 Aug 2020 15:36:06 +0200 In-Reply-To: <87k0xfib4b.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 31 Aug 2020 08:27:00 +0200") Message-ID: <87h7sjc4zd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: PdGrMHlajoBb Hi, Mathieu Othacehe skribis: >> Why not just change the caller to pass #:mounts '() then? Am I missing >> something? >> >> I=E2=80=99m reluctant to introducing =E2=80=9Cjail=E2=80=9D because that= =E2=80=99s undefined in this >> context (reminds me of FreeBSD). > > The purpose here is to avoid the "pivot-root" call that is done > unconditionally in "mount-file-systems". This way containerized process > can share the parent root file-system. Oh, I see. > Maybe something like that would make more sense: > > (lambda () > (unless (null? mounts) > (mount-file-systems root mounts > #:mount-/proc? (memq 'pid namespaces) > #:mount-/sys? (memq 'net > namespaces)))) Should it be (and (null? mounts) (null? namespaces)) or=E2=80=A6? Ludo=E2=80=99.