From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id fBiMGoAGWl9QRwAA0tVLHw (envelope-from ) for ; Thu, 10 Sep 2020 10:57:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QBP7FYAGWl+BUAAAB5/wlQ (envelope-from ) for ; Thu, 10 Sep 2020 10:57:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A27289408DD for ; Thu, 10 Sep 2020 10:57:03 +0000 (UTC) Received: from localhost ([::1]:47470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGKGC-0006xp-Jw for larch@yhetil.org; Thu, 10 Sep 2020 06:57:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGKEJ-0003eZ-By for guix-patches@gnu.org; Thu, 10 Sep 2020 06:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGKEI-0005xw-CS for guix-patches@gnu.org; Thu, 10 Sep 2020 06:55:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGKEI-00054y-9v for guix-patches@gnu.org; Thu, 10 Sep 2020 06:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43159] [PATCHES v2] scripts: Use 'define-command' and have 'guix help' use that. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Sep 2020 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43159 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43159@debbugs.gnu.org, zimon.toutoune@gmail.com, efraim@flashner.co.il, maxim.cournoyer@gmail.com, 43159-done@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, zimoun , Efraim Flashner , Maxim Cournoyer , 43159-done@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159973524419451 (code B ref -1); Thu, 10 Sep 2020 10:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Sep 2020 10:54:04 +0000 Received: from localhost ([127.0.0.1]:37314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGKDL-00053Z-OK for submit@debbugs.gnu.org; Thu, 10 Sep 2020 06:54:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:60260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGKDI-000538-9b for submit@debbugs.gnu.org; Thu, 10 Sep 2020 06:54:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGKDH-0002aK-U6 for guix-patches@gnu.org; Thu, 10 Sep 2020 06:54:00 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGKDF-0005sp-ER; Thu, 10 Sep 2020 06:53:59 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1599735233; cv=none; d=zohomail.com; s=zohoarc; b=Ljjgsl06sbej7ZxLrKEsc11yRWtE7RfEfWE7LuzSNpo6z0+oJhWRagiO9yp9E2ElQARZ6WbPQdDvO47W7PJO3a7y7CEWLp463h6AaaJtPdHIqSGerCNLhbtbKtncqyxNjin6tLb5Lfpgxhk7TqiHfBVLeMNQeiJTVvDUSbkJi6A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599735233; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=pxMe05DcpXgpcjWbpq6PchA1mGjl6lN6aPNIEYL15lg=; b=jTyfytdZOkT9NI86wMO/mOkdRMSeKBCoIBn8qaaQgqMayAVORvEJSYTuInJJXnqnqI2kWy2nS4dL35rVjQxDPWQveaD/IreGbYXlXbJWuSDQe1BjtPm/ide8l50CckUyQpLD/SFj/Dq2dP7Cl8EI4V/QQUWakbfdPM6GYHMFd9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1599735233; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=pxMe05DcpXgpcjWbpq6PchA1mGjl6lN6aPNIEYL15lg=; b=BDci1STs9JW5S7njs5P/cIToS7Iym7oTQQhWrvOrFzljA6J7wdzZ2INo8Fzym/4i RUU06nA7W4I8EiT0BfPUGeAGECouGZWKir2HrtLL8HinYKnO/2lRyWqNh0dUrzP08Cr N+9HGSFrCx1QaNLnxsUaPYKNvOgz1E3N4U18CpfA= Received: from localhost (p54ad4af6.dip0.t-ipconnect.de [84.173.74.246]) by mx.zohomail.com with SMTPS id 1599735231122711.0382652229035; Thu, 10 Sep 2020 03:53:51 -0700 (PDT) References: <20200901203520.21103-1-ludo@gnu.org> <20200901204136.21375-1-ludo@gnu.org> <87r1rk595p.fsf@gmail.com> <87tuw9iw34.fsf_-_@gnu.org> <874ko5hqd5.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus In-reply-to: <874ko5hqd5.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 10 Sep 2020 12:55:04 +0200 Message-ID: <87h7s56gvr.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 06:37:33 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=elephly.net header.s=zoho header.b=BDci1STs; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 3.49 X-TUID: 6bw9ZDEtUhQo I=E2=80=99m a bit late, but I=E2=80=99m very happy to see that =E2=80=9Cfor= developers=E2=80=9D has become =E2=80=9Cfor development=E2=80=9D! Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> Here=E2=80=99s a v2 of the patches, where I tried to take your feedback = into >> account. Changes: >> >> =E2=80=A2 Categories that appear in uses of =E2=80=98define-command=E2= =80=99 are now validated >> at macro-expansion time. Neat! >> =E2=80=A2 (guix scripts) contains an alist of the known categories and >> =E2=80=98show-help=E2=80=99 traverses it. Knowing that guile-config exists for automatically generating help screens, configuration files, command line options, and all that I wonder if there=E2=80=99s anything here that could become part of guile-con= fig and move out of Guix. I had been in that situation myself where I felt that guile-config may not be a great fit for my help texts because of minor quibbles about the format or the way things are presented by default. In the end I decided to use guile-config, because I prefer to have this handled by someone else who keeps thinking about the problems relating to argument parsing, configuration files, and help texts. It may not be a great fit for Guix now, but I wonder if it could. In the long run I think it would be good for Guix to become a little less special =E2=80=94 no matter if that=E2=80=99s monad macros, records, argpar= sing, or configuration files. This is not a recommendation either way. I just wonder if in the long term we could benefit from moving all this to a separate package. >> =E2=80=A2 Changed the label for development commands to =E2=80=9Ccomma= nds for >> development=E2=80=9D, and changed =E2=80=9Cadvanced=E2=80=9D to =E2= =80=9Cplumbing=E2=80=9D. >> >> =E2=80=A2 Added a =E2=80=9Cpackaging=E2=80=9D category. >> >> =E2=80=A2 Fixed the typos you reported. > > I pushed this v2 as 3794ce93be8216d8378df7b808ce7f53b1e05a53. Excellent! Thank you! --=20 Ricardo