From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund@posteo.net>
Cc: 43551@debbugs.gnu.org
Subject: [bug#43551] [PATCH] Add package emacs-quickrun
Date: Tue, 22 Sep 2020 11:07:06 +0200 [thread overview]
Message-ID: <87h7rq9o3p.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zh5jxkt6.fsf@posteo.net> (Niklas Eklund's message of "Mon, 21 Sep 2020 16:32:05 +0200")
Hello,
Niklas Eklund <niklas.eklund@posteo.net> writes:
> Subject: [PATCH] gnu: Add emacs-quickrun.
Thank you.
> +(define-public emacs-quickrun
> + (let ((commit "0133cac651918071a824e85b55e10d44f32a1979")
> + (revision "0"))
I don't think there is any reason to use a commit directly, since this
one matches a release.
> + (package
> + (name "emacs-quickrun")
> + (version (git-version "2.3.1" revision commit))
(version "2.3.1")
is enough per above.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/emacsorphanage/quickrun")
> + (commit commit)))
(commit version)
> + (sha256
> + (base32
> + "0a1n2v09h0n7d9p2izflqqang4ny0b46dlqvmxvkkik4bb6f4wcz"))
Please move the hash string on the same line as base32.
> + (file-name (git-file-name name version))))
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/emacsorphanage/quickrun")
Please move the URL on the same line as home-page
> + (synopsis "Run commands quickly")
> + (description
> + "This package evaluates the content of a buffer, or region and displays
> +the result. It is similar to executable-interpret, but provides more
> +convenient commands. Quickrun execute not only script languages(Perl, Ruby,
Quickrun executes ... languages (Perl
> +Python etc), but also compiling languages(C, C++, Go, Java etc) and
> markup
Mind the missing space here, too.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-09-22 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 14:32 [bug#43551] [PATCH] Add package emacs-quickrun Niklas Eklund
2020-09-22 9:07 ` Nicolas Goaziou [this message]
2020-09-22 9:33 ` Niklas Eklund
2020-09-22 12:37 ` Niklas Eklund
2020-09-23 19:39 ` bug#43551: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7rq9o3p.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43551@debbugs.gnu.org \
--cc=niklas.eklund@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).