From: Christopher Baines <mail@cbaines.net>
To: 40654-done@debbugs.gnu.org
Subject: bug#40654: [PATCH] gnu: gnutls: Enable p11-kit.
Date: Wed, 21 Oct 2020 21:50:54 +0100 [thread overview]
Message-ID: <87h7qngv69.fsf@cbaines.net> (raw)
In-Reply-To: <20200416083409.6230-1-mail@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 2685 bytes --]
Christopher Baines <mail@cbaines.net> writes:
> Everywhere except mips64el, where a comment says it doesn't work. I can't test
> as I can't build this on mips64el anyway.
>
> This change will enable running the tests for libcacard.
>
> * gnu/packages/tls.scm (gnutls)[arguments]: Only specify --without-p11-kit on
> mips64el.
> [inputs]: Include the p11-kit for all systems except mips64el.
> ---
> gnu/packages/tls.scm | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
> index 3eb32fc27a..85f159a401 100644
> --- a/gnu/packages/tls.scm
> +++ b/gnu/packages/tls.scm
> @@ -181,7 +181,7 @@ living in the same process.")
> `(; Ensure we don't keep a reference to this buggy software.
> #:disallowed-references (,net-tools)
> #:configure-flags
> - (list
> + (cons*
> ;; GnuTLS doesn't consult any environment variables to specify
> ;; the location of the system-wide trust store. Instead it has a
> ;; configure-time option. Unless specified, its configure script
> @@ -202,9 +202,14 @@ living in the same process.")
> (string-append "--with-guile-extension-dir="
> "$(libdir)/guile/$(GUILE_EFFECTIVE_VERSION)/extensions")
>
> - ;; FIXME: Temporarily disable p11-kit support since it is not
> - ;; working on mips64el.
> - "--without-p11-kit")
> + (let ((system ,(or (%current-target-system)
> + (%current-system))))
> + (if (string-prefix? "mips64el" system)
> + (list
> + ;; FIXME: Temporarily disable p11-kit support since it is
> + ;; not working on mips64el.
> + "--without-p11-kit")
> + '())))
>
> #:phases (modify-phases %standard-phases
> (add-after
> @@ -227,7 +232,12 @@ living in the same process.")
> ("pkg-config" ,pkg-config)
> ("which" ,which)))
> (inputs
> - `(("guile" ,guile-2.2)))
> + `(("guile" ,guile-2.2)
> + ,@(let ((system (or (%current-target-system)
> + (%current-system))))
> + (if (string-prefix? "mips64el" system)
> + '()
> + `(("p11-kit" ,p11-kit))))))
> (propagated-inputs
> ;; These are all in the 'Requires.private' field of gnutls.pc.
> `(("libtasn1" ,libtasn1)
I've pushed this to core-updates now as
1c2889b1ce08e1f91193e237e03462dc74c63726.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
prev parent reply other threads:[~2020-10-21 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 8:34 [bug#40654] [PATCH] gnu: gnutls: Enable p11-kit Christopher Baines
2020-04-16 12:16 ` Jakub Kądziołka
2020-04-16 17:37 ` Christopher Baines
2020-10-21 20:50 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7qngv69.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=40654-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).