From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 46668@debbugs.gnu.org
Subject: [bug#46668] [PATCH]: tests: do not hard code HTTP ports
Date: Mon, 01 Mar 2021 22:40:18 +0100 [thread overview]
Message-ID: <87h7lupn7h.fsf@gnu.org> (raw)
In-Reply-To: <3ae8be5f05d73106c867fe2cfc7f619673fd738b.camel@telenet.be> (Maxime Devos's message of "Mon, 01 Mar 2021 18:23:00 +0100")
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> You made some comments about ‘Hunks that shouldn't be here’ below.
> I disagree. As my explanation is exactly the same for almost all hunks,
> I've numbered them and the explanations.
>
> Explanations:
>
> A. (Hunk 2--12, i.e. all hunks except the first)
> In some tests, the port number is hardcoded.
> E.g., you'll see (test-equal "Some string http://localhost:9999" expression).
> Removing the hard-coding is the whole point of this patch.
> B. See later (hunk #1).
> C. See later (hunk #2).
Oooh I see, my bad! I thought ‘test-equal’ & co. were vanishing, when
in fact they were just moved down. Your explanations make perfect
sense.
IWBN to keep the (test-xyz …) forms at the top level as much as possible
(it’s more convenient, especially when working from Geiser); when it’s
not possible, changes like you did are the right thing.
Thank you, and apologies for the confusion!
Ludo’.
next prev parent reply other threads:[~2021-03-01 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 22:00 [bug#46668] [PATCH]: tests: do not hard code HTTP ports Maxime Devos
2021-03-01 15:46 ` Ludovic Courtès
2021-03-01 17:23 ` Maxime Devos
2021-03-01 21:40 ` Ludovic Courtès [this message]
2021-03-02 8:15 ` Maxime Devos
2021-03-02 21:29 ` Ludovic Courtès
2021-03-02 21:49 ` Maxime Devos
2021-03-06 10:23 ` bug#46668: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7lupn7h.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=46668@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).