From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oPhTBGsldGDnRAAAgWs5BA (envelope-from ) for ; Mon, 12 Apr 2021 12:48:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uJqbOWoldGBdTwAAB5/wlQ (envelope-from ) for ; Mon, 12 Apr 2021 10:48:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9ABC81EA45 for ; Mon, 12 Apr 2021 12:48:10 +0200 (CEST) Received: from localhost ([::1]:39818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVu6z-0007so-BS for larch@yhetil.org; Mon, 12 Apr 2021 06:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVu6s-0007na-LP for guix-patches@gnu.org; Mon, 12 Apr 2021 06:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVu6s-0001Y6-Da for guix-patches@gnu.org; Mon, 12 Apr 2021 06:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVu6s-00011g-BF for guix-patches@gnu.org; Mon, 12 Apr 2021 06:48:02 -0400 Subject: bug#47540: [PATCH] gnu: Add prips. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 12 Apr 2021 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47540 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: david larsson Cc: 47540-done@debbugs.gnu.org, Maxime Devos Mail-Followup-To: 47540@debbugs.gnu.org, ludo@gnu.org, david.larsson@selfhosted.xyz Received: via spool by 47540-done@debbugs.gnu.org id=D47540.16182244723921 (code D ref 47540); Mon, 12 Apr 2021 10:48:02 +0000 Received: (at 47540-done) by debbugs.gnu.org; 12 Apr 2021 10:47:52 +0000 Received: from localhost ([127.0.0.1]:56610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVu6i-00011B-Dx for submit@debbugs.gnu.org; Mon, 12 Apr 2021 06:47:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVu6g-00010x-Ga for 47540-done@debbugs.gnu.org; Mon, 12 Apr 2021 06:47:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51559) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVu6Z-0001Jh-DC; Mon, 12 Apr 2021 06:47:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47860 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVu6Y-0005zE-Tb; Mon, 12 Apr 2021 06:47:43 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> <96ad7a4cc63b104b2cc5eac5997b6ac2854fe101.camel@telenet.be> <444cc65de656858b59e577dce74009bb@selfhosted.xyz> Date: Mon, 12 Apr 2021 12:47:41 +0200 In-Reply-To: <444cc65de656858b59e577dce74009bb@selfhosted.xyz> (david larsson's message of "Thu, 08 Apr 2021 21:28:59 +0200") Message-ID: <87h7kbrd82.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618224490; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+RnUrLXmYPe8D9VPzeTxylY5pGU3bYeu5wrivt37TzE=; b=ULoNjAfjRPiimAFgN7e+i1fiSuc09JzSXSqNEWrhO4tGeIdSHuvucBmC4Y5H/jwKekKEHl BF8woA/wqffpe734FV9gDJCwYHsmcGXkAc2oIJNhPunt71Wb/qJAZJodKDUEFYkyMvxs3t SpApTevhGzUKSKRHxnw+odRdZj9eiPBrBwA8JMFtAdxxk9zprni2pgtXdeaxvCOm8bX32e qMsO36zNXu7M3ixQdFrQ02YSvg9kXFoTOfScGPudk4FsWnVU19XknQqPHXzcB2FAjlgnbM nh5fO4UOukPbxmqNoiKRfPyhdeoJy2y8C66ZBxvLDIA9B+MZgxHUIX4fsNqknA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618224490; a=rsa-sha256; cv=none; b=K0zm5FLkOChd8HXnfUCgQi09UVatH8Q8o5HC7bxHOHBiClOklc2FhVs2ysTEHkuwS3xNiA d3vLphzqcsw5OeIptZubEgY3+EnpSCeh4O0zTeJGlh0jFokW0XuLYL3a4pophqKzT2oJS8 LVrCx2DOr7fp8eBp8qEL2KONHKwEKIcQ/ascU8xbFf9SmErheXb0p0BUwKH10hdkjUPEpz WAJsm5yJP+N7jVMIL7/C/Yu8Ej0tDTgPuUbKi5zPuMinvKm0s2iDETPirRUbvoHWopYv04 casHxndcG35d8EWVrFDZlyYs1uxAlv7PjsRQlMVLChBxreobiYRc+ClpoL41vg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9ABC81EA45 X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: 03rUmmWl8UFU --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, david larsson skribis: > From 85cf7b9d22801d9b3bac8956b358fce4c32dcb4c Mon Sep 17 00:00:00 2001 > From: methuselah-0 > Date: Thu, 8 Apr 2021 21:26:23 +0200 > Subject: [PATCH] gnu: Add prips. > > gnu/packages/admin.scm (prips): New variable. [...] > + (replace 'install > + (lambda _ > + (let* > + ((bin-dir (string-append %output "/bin")) > + (bin-file (string-append bin-dir "/prips"))) > + (mkdir-p bin-dir) > + (copy-file "prips" bin-file) > + (chmod bin-file #o600))))))) That installed a non-executable file. I fixed this with the patch below, which also make the style more consistent. Thanks David, and thanks Maxime for the review! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index f3e8774b75..512ac320e6 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -1070,13 +1070,10 @@ recursive runs on the generated subnets. (also IPv6) #:phases (modify-phases %standard-phases (delete 'configure) (replace 'install - (lambda _ - (let* - ((bin-dir (string-append %output "/bin")) - (bin-file (string-append bin-dir "/prips"))) - (mkdir-p bin-dir) - (copy-file "prips" bin-file) - (chmod bin-file #o600))))))) + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (install-file "prips" + (string-append out "/bin")))))))) (native-inputs `(("perl-test-harness" ,perl-test-harness))) (synopsis "Tool that prints the IP addresses in a given range") (description "Prips can be used to print all of the IP addresses in --=-=-=--