unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Morgan.J.Smith@outlook.com
Cc: 48205@debbugs.gnu.org
Subject: [bug#48205] [PATCH] gnu: emacs-org: Make build reproducible
Date: Tue, 11 May 2021 12:28:46 +0200	[thread overview]
Message-ID: <87h7j936ox.fsf@gnu.org> (raw)
In-Reply-To: <BYAPR05MB40239B904A0A20F4BFB8B2A6C55B9@BYAPR05MB4023.namprd05.prod.outlook.com> (Morgan J. Smith's message of "Mon, 3 May 2021 16:54:44 -0400")

Hi,

Morgan.J.Smith@outlook.com skribis:

> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/emacs-xyz.scm (emacs-org)[phases]: Remove loaddefs and use
> autoloads instead

[...]

> +         (add-after 'fix-org-version 'use-autoloads
> +           (lambda _
> +             (delete-file "org-loaddefs.el")
> +             (substitute* (find-files "." ".*.el")
> +                 (("org-loaddefs.el") "org-autoloads.el"))
> +             #t))

You can drop the trailing #t.

Could you explain in a comment in the phase what it does?  It’s not
clear to me how this relates to making the build bit-reproducible.

Remember that ‘find-files’ takes a regexp as its second argument; thus,
to match .el files, you need to write "\\.el$".

Could you send an updated patch?

Thanks,
Ludo’.




  reply	other threads:[~2021-05-11 10:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 20:54 [bug#48205] [PATCH] gnu: emacs-org: Make build reproducible Morgan.J.Smith
2021-05-11 10:28 ` Ludovic Courtès [this message]
2021-06-09 15:32 ` [bug#48205] [PATCH v2] " Morgan.J.Smith
2021-06-11 22:54   ` Ludovic Courtès
2021-11-26  5:12 ` [bug#48205] [PATCH] gnu: emacs-org: Don't use release tar Morgan.J.Smith
2021-11-28 21:01   ` bug#48205: " Nicolas Goaziou
2021-12-02  1:57     ` [bug#48205] " Michael Rohleder
2021-12-02 17:38 ` [bug#48205] [PATCH] gnu: emacs-org: Preserve version information Morgan.J.Smith
2021-12-03 20:15   ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7j936ox.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=48205@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).