From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MKqNKaXLoGDISQAAgWs5BA (envelope-from ) for ; Sun, 16 May 2021 09:37:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +F8oJaXLoGAjNwAAbx9fmQ (envelope-from ) for ; Sun, 16 May 2021 07:37:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70023E8C4 for ; Sun, 16 May 2021 09:37:09 +0200 (CEST) Received: from localhost ([::1]:57842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liBKm-0000RM-F0 for larch@yhetil.org; Sun, 16 May 2021 03:37:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liBKg-0000RC-32 for guix-patches@gnu.org; Sun, 16 May 2021 03:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38091) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liBKf-0008Ep-Rj for guix-patches@gnu.org; Sun, 16 May 2021 03:37:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1liBKf-0000Jt-Pt for guix-patches@gnu.org; Sun, 16 May 2021 03:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48459] [PATCH 1/3] gnu: tracker: Add missing dependencies. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 May 2021 07:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48459 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Raghav Gururajan Cc: 48459@debbugs.gnu.org Received: via spool by 48459-submit@debbugs.gnu.org id=B48459.16211506121212 (code B ref 48459); Sun, 16 May 2021 07:37:01 +0000 Received: (at 48459) by debbugs.gnu.org; 16 May 2021 07:36:52 +0000 Received: from localhost ([127.0.0.1]:49637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liBKV-0000JU-U5 for submit@debbugs.gnu.org; Sun, 16 May 2021 03:36:52 -0400 Received: from mira.cbaines.net ([212.71.252.8]:38188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liBKT-0000JL-AE for 48459@debbugs.gnu.org; Sun, 16 May 2021 03:36:51 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 3718127BC78; Sun, 16 May 2021 08:36:48 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 0d020ee0; Sun, 16 May 2021 07:36:47 +0000 (UTC) References: <20210516050759.7239-1-rg@raghavgururajan.name> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines In-reply-to: <20210516050759.7239-1-rg@raghavgururajan.name> Date: Sun, 16 May 2021 08:36:45 +0100 Message-ID: <87h7j3cepe.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 70023E8C4 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1cQZj37WrWHP --=-=-= Content-Type: text/plain Raghav Gururajan via Guix-patches via writes: > * gnu/packages/gnome.scm (tracker)[native-inputs]: Add python-wrapper. > [inputs]: Add bash-completion, network-manager and libstemmer. > [propagated-inputs]: Add glib. Missing in my mind implies something was broken because of the missing dependencies, and if that's the case, it would be good to note what adding these missing dependencies fixes. If these are just additional dependencies, it would also be good to note what the addition of these dependencies enables. > --- > gnu/packages/gnome.scm | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index be458c07bb..882b643067 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -133,6 +133,7 @@ > #:use-module (gnu packages inkscape) > #:use-module (gnu packages iso-codes) > #:use-module (gnu packages kerberos) > + #:use-module (gnu packages language) > #:use-module (gnu packages libcanberra) > #:use-module (gnu packages libffi) > #:use-module (gnu packages libunistring) > @@ -8753,14 +8754,20 @@ easy, safe, and automatic.") > ("python-pygobject" ,python-pygobject) > ("intltool" ,intltool) > ("pkg-config" ,pkg-config) > + ("python" ,python-wrapper) ; she-bangs shebang is one (very odd word): https://en.wikipedia.org/wiki/Shebang_(Unix) That doesn't help me to understand what this (native?) input is being added for though? > ("vala" ,vala))) > (inputs > - `(("dbus" ,dbus) > + `(("bash-completion" ,bash-completion) ; bash-completions I'm not sure what the comment adds here? > + ("dbus" ,dbus) > ("sqlite" ,sqlite) > ("libxml2" ,libxml2) > - ("icu4c" ,icu4c) ; libunistring gets miner-miner-fs test to fail. > + ("icu4c" ,icu4c) ; libunistring gets miner-miner-fs test to fail. > ("json-glib" ,json-glib) > - ("libsoup" ,libsoup))) > + ("libnm" ,network-manager) ; network status detection This comment is useful. > + ("libsoup" ,libsoup) > + ("stemmer" ,libstemmer))) ; stemming I don't think this comment adds anything. > + (propagated-inputs > + `(("glib" ,glib))) ; referenced in .pc files This one does though. > (synopsis "Metadata database, indexer and search tool") > (home-page "https://wiki.gnome.org/Projects/Tracker") > (description --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmCgy41fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfH/BAAuGkeoi9Rg3W5ZD8fjP6CGSpHPKN5aGrm EvXcjFuOnuWI94U8lN+9yM6xru1G9z9olFzPrvxx/+OfmqBIkBndBzZKoui1Brso 71+SCGJDwt8CwbYLGL7itu5xybx6STZtqqZoHfrC9mb8d2qR8kZF3mcQpaukB/By HGZ5FXbci2Q6J5Gzx25Hrmi9JCqFXOXyHKWzZk3NBmixyMaJ99yYCTEEBmV/MuUq rOW/5d2ZBhykMpWOX7glcv7TnX5yGssNMluRS6/VANrWwcVZpK653pjIPm+Q00uV FV1WK+JybN9KAOAV9hYrdjZctDPecnCMY/s22zxnFpw1+msUo74ewE9YV8nKn7zn 4uYjhZsyuTm/zV0hkLb3/nSYz8GtFuIYit4B81lRCOyZL+VZxdM5mg0xaJqn9MqA +VYbhkOoarf2CZ92DHi1RI0z7JZx7sP6IyGw7CDRxdnuMAXZZp8UxHEgyR+nouJf l9OObNiBEmio9ESswyU1QdHdAPx194br9QwXldt+ieKxWX3K/qZ2cW5YMm+awQv2 hxGCtDnHrzkv+XGXDNdj5/Q5A8L3aHpaxo/gbIVX84nyEJyygqOmblIl0rDHvrrA ADJHa/t1c9YCtQ1SXkhDRJREIodNqancjvi3byoJRlUgWfEAvpt0l6nJlun3uWta 5L8qRNxAV8Y= =UlsY -----END PGP SIGNATURE----- --=-=-=--