From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ABzoHvI3LmHLEwEAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 16:08:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kNK0GvI3LmF2MwAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 14:08:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F1156158D7 for ; Tue, 31 Aug 2021 16:08:49 +0200 (CEST) Received: from localhost ([::1]:38392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL4RU-0008JR-V4 for larch@yhetil.org; Tue, 31 Aug 2021 10:08:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL42Y-0008KV-CY for guix-patches@gnu.org; Tue, 31 Aug 2021 09:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL42X-0007x4-PW for guix-patches@gnu.org; Tue, 31 Aug 2021 09:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mL42X-0004SI-Jg for guix-patches@gnu.org; Tue, 31 Aug 2021 09:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50261] [PATCH] gnu: node: Enable cross-compilation. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Aug 2021 13:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50261 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 50261@debbugs.gnu.org Received: via spool by 50261-submit@debbugs.gnu.org id=B50261.163041733517057 (code B ref 50261); Tue, 31 Aug 2021 13:43:01 +0000 Received: (at 50261) by debbugs.gnu.org; 31 Aug 2021 13:42:15 +0000 Received: from localhost ([127.0.0.1]:33300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL41n-0004R3-6z for submit@debbugs.gnu.org; Tue, 31 Aug 2021 09:42:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL41k-0004Qm-77 for 50261@debbugs.gnu.org; Tue, 31 Aug 2021 09:42:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36118) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL41e-0007Ep-K5; Tue, 31 Aug 2021 09:42:06 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=37380 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL41H-0008Pw-TC; Tue, 31 Aug 2021 09:41:51 -0400 From: Mathieu Othacehe References: <87a6kzsu92.fsf@gmx.com> Date: Tue, 31 Aug 2021 15:41:39 +0200 In-Reply-To: <87a6kzsu92.fsf@gmx.com> (Pierre Langlois's message of "Sun, 29 Aug 2021 23:06:00 +0100") Message-ID: <87h7f568a4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630418930; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=1tFGPe5Mu27DyakiJkp56GJe69xx+D3NJxk0TsbTvLw=; b=hlGggPyQ/bcOOEnF8eb/o37aVl9YC2t9PdJR6FDVEiw3l3awl2X7C5iRZdn+V+GWU4AQD7 60qjJ4EAX72TNvAeHF6/tGwFbsr/IwYZGWV+SuDU/+G5n344KhDd2npu83KFCE13BbmMgU Yp0yq1nO7jRLyX+pm+ySP6+4RAHdH/XuzxghaDUmsJCknFD5fWWQXrUj81Vba6k2YZygkt 15rwsK64Sw92MrzAUjk/5cKdoS+qa9kG5DUTBI8wkGVz/VhenQT4/Khu2nAwEw3dRXCBeT mbWe1c6MQI15uT5Z0liab1wxqYwOxPEHpYrKb7V4XUJNWpEzTPtW2tsLHlIaFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630418930; a=rsa-sha256; cv=none; b=GPGXRy8hI1zjw3774mAEVid42s7fLuHyFya39yFo7z2fXfsyJtJwMLycM3m/4F/mJkZyz5 3K3ix+qd0NtpkpvYt8ml+IeIwonfgFob5J1IRjenK5EyajqAe3Nmipq2ABiWchikftkqn2 bSuV7CQqNKKEOsDi8CpjedsKYOVF/Z31iheIKGb4GEaI3BtOCfVGoUAEA3fBtL4+qs7mA4 1Wm/YhuV6iNQilbKQnNocKRvK4NuzkufwvqJIeav8RUqKG1kRmpVsZCgc/Rg8EJLkyLgtU 0cVP+9ZIDRW/GV8a5TmrnSzOgksdAclOqNS6+B6svx0g5uYMQp+TWgTKcBZF9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F1156158D7 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: Vhl4+3nSqoE8 Hello Pierre, > While working on tree-sitter I realized our node packages didn't > cross-compile [0] so I thought I'd give it a go, here's a patch! Nice! > I'm not sure there's any way to express this restriction in the package > definition, it would be good to fail in a useful way, any thoughts? I > suspect a mechanism for this isn't really worth the effort, I don't know > of any other packages like this. Yeah that's a strange limitation, I don't think we have something similar elsewhere. A restriction that compares the host and target bitness is maybe not worth it. > - (string-append (assoc-ref inputs "python") > + (string-append (assoc-ref (or native-inputs inputs) "python") You have several lines such as this one that are longer than the 78 columns limit. Other than that, it looks cool, and you can go ahead. Thanks, Mathieu