From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6CCMFdC+OGFC3AAAgWs5BA (envelope-from ) for ; Wed, 08 Sep 2021 15:46:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mDsCEdC+OGHXCwAAbx9fmQ (envelope-from ) for ; Wed, 08 Sep 2021 13:46:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0EA2A17D1E for ; Wed, 8 Sep 2021 15:46:56 +0200 (CEST) Received: from localhost ([::1]:59670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNxuh-0003ip-5S for larch@yhetil.org; Wed, 08 Sep 2021 09:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNxtr-0003Qj-20 for guix-patches@gnu.org; Wed, 08 Sep 2021 09:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNxtq-00034f-P1 for guix-patches@gnu.org; Wed, 08 Sep 2021 09:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNxtq-0005ZU-N6 for guix-patches@gnu.org; Wed, 08 Sep 2021 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50286] [RFC PATCH] Let 'package-location' returns location of surrounding 'let'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Sep 2021 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50286 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: Maxime Devos , 50286@debbugs.gnu.org Received: via spool by 50286-submit@debbugs.gnu.org id=B50286.163110874221350 (code B ref 50286); Wed, 08 Sep 2021 13:46:02 +0000 Received: (at 50286) by debbugs.gnu.org; 8 Sep 2021 13:45:42 +0000 Received: from localhost ([127.0.0.1]:59042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNxtV-0005YH-U0 for submit@debbugs.gnu.org; Wed, 08 Sep 2021 09:45:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNxtU-0005Y5-7c for 50286@debbugs.gnu.org; Wed, 08 Sep 2021 09:45:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42306) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNxtN-0002cR-GO; Wed, 08 Sep 2021 09:45:33 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35396 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNxsz-00037l-Rl; Wed, 08 Sep 2021 09:45:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <0b61652d751633f78e876a27be88ed14e47527b6.camel@telenet.be> <87o89681br.fsf@gnu.org> <875yvc4254.fsf_-_@gnu.org> <86wnnsgn0r.fsf@mgsn.dev> Date: Wed, 08 Sep 2021 15:45:07 +0200 In-Reply-To: <86wnnsgn0r.fsf@mgsn.dev> (Sarah Morgensen's message of "Tue, 07 Sep 2021 13:15:48 -0700") Message-ID: <87h7ev2nbw.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631108816; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=70J7VR2rBkyGMgIrKt81bV7kmEmS54Es0kkQoSIHivo=; b=Qv7weFcsWAeCTlfUatz9ypm7qF5muWeR59g8FG5rCB1l7MfSVBhMrqz7Pc0/YpfqxxfrYt dRnjQ7Zcf8NJsgznWA/30KxEEK0x7LNDTpvi0dHCRjXSNFfJGDyHOw7mVN9dqiKyxmbJuF 0TYpGMRuX+mmLVrwhZ9jk/8hYorD9Vdr9pJ+ZfAMfqRzQNgcVMA1AgILQo6L8OdLHtufXk Z4dMyg4q6FsnO8kOiHGrUTcOWZwlkQkbGB8uVjQ41G/+t4YdC3zQMHF74KXBc1vtIgb5FW j2Jd1vW2FIj3ZZNfpTuSpdvZ87GduOb1Z1oUIluCT99WPqMX8OJlN4Eo2ZDTYw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631108816; a=rsa-sha256; cv=none; b=U4jx2YnCFJ16GpoUG+SwlZsPLnq8Qh3yonuVS1DAnlH2T2pYX9HcyE6uzyT4ROnuyNaA15 SQUC2o86M7fgXQMWqWmHjAx0xcMQ7GONaVHtW5WVPp+nMtS229h3Lhxi66XZbLVlTSEtWC 9VxBo2H0r+BHQccb/YtRSaXddGjO/1iAVa3o+mk2DTv6bGnmtLbANxdEYGbbsJ/mPA4wlw NrbXawru4s1P5MOHKE+BWd25195kcKW+HwKNlHmXgVqKVQV4ty1ZTUWn0kqauXvECCGTWG 5RZQYTUecZOd3pLd1kZwQ9rn7Qb5ADC/zvgqmkX+SG3qeKB7nooLuFje/1HcXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0EA2A17D1E X-Spam-Score: -2.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: MH/HhqzJlrgX Hi Sarah, Sarah Morgensen skribis: > However... it doesn't work for unexported packages. It looks there are > about 200 such packages: > > ~/guix$ rg -U '\(define [^\(]+\n.*?\(package' gnu/packages --count --no-f= ilename | awk '{a+=3D$1} END {print a}' > 233 Ah, hmm, well. I=E2=80=99d have said these are beyond our scope :-), and in fact we=E2=80=99d need to know how many among these 233 packages use the (let ((commit =E2=80=A6)) =E2=80=A6) idiom, but if this is deemed important= , we can replace =E2=80=98define=E2=80=99 similarly. > And, to play the pessimist: > > What do we get out of this that couldn't be done by "go to package > location; read backwards one sexp until we reach a defining form" > (like Emacs' 'beginning-of-defun')? Nothing! It=E2=80=99s just easier to implement and more accurate=E2=80=94w= e=E2=80=99re sure to get the exact location of the =E2=80=98define-public=E2=80=99 form that sur= rounds the package record we=E2=80=99re looking at. Now, longer-term, I=E2=80=99d like to have Emacs/paredit-like features and = more tools to correlate source and live objects. I found myself doing a bit of that in =E2=80=98guix style=E2=80=99, and I think that=E2=80=99s a fun a= rea to explore so we can improve our package maintenance tools. Thanks, Ludo=E2=80=99.