[bug#50439] [PATCH] gnu: Add av-98

[Xinglu Chen <public@yoctocell.xyz>]

[-- Attachment #1: Type: text/plain, Size: 5901 bytes --]

On Fri, Sep 10 2021, Christopher Howard wrote:

> Patch has been attached with the requested changes.
>
> -- 
> Christopher Howard
> Gemini capsule: gemini://gem.librehacker.com
> Web version: https://proxy.vulpes.one/gemini/gem.librehacker.com
>
>
> On Wed, 2021-09-08 at 20:50 +0200, Xinglu Chen wrote:
>> On Mon, Sep 06 2021, Christopher Howard wrote:
>> 
>> > This patch adds `av-98`, a command-line Gemini browser.
>> > 
>> > -- 
>> > Christopher Howard
>> > Gemini capsule: gemini://gem.librehacker.com
>> > Web version: https://proxy.vulpes.one/gemini/gem.librehacker.com
>> > 
>> > From 6695c286ef661924f8c666f645be4830dfaff70f Mon Sep 17 00:00:00 2001
>> > From: Christopher Howard <christopher@librehacker.com>
>> > Date: Mon, 6 Sep 2021 11:42:09 -0800
>> > Subject: [PATCH] gnu: Add av-98
>> > 
>> > * gnu/packages/web-browsers.scm (av-98): New variable.
>> > ---
>> >  gnu/packages/web-browsers.scm | 19 +++++++++++++++++++
>> >  1 file changed, 19 insertions(+)
>> > 
>> > diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
>> > index be4fa61a37..f7faeab89f 100644
>> > --- a/gnu/packages/web-browsers.scm
>> > +++ b/gnu/packages/web-browsers.scm
>> > @@ -19,6 +19,7 @@
>> >  ;;; Copyright © 2021 Benoit Joly <benoit@benoitj.ca>
>> >  ;;; Copyright © 2021 Alexander Krotov <krotov@iitp.ru>
>> >  ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
>> > +;;; Copyright © 2021 Christopher Howard <christopher@librehacker.com>
>> >  ;;;
>> >  ;;; This file is part of GNU Guix.
>> >  ;;;
>> > @@ -903,3 +904,21 @@ interface.")
>> >      (synopsis "Gemini client with a terminal interface")
>> >      (description "Telescope is a w3m-like browser for Gemini.")
>> >      (license license:x11)))
>> > +
>> > +(define-public av-98
>> > +  (package
>> > +    (name "av-98")
>> > +    (version "1.0.1")
>> > +    (source
>> > +     (origin
>> > +       (method url-fetch)
>> > +       (uri (pypi-uri "AV-98" version))
>> 
>> I noticed that the PyPi updater mistakes the package for the ‘av’[1]
>> package and says that it can updated to version 8.0.3.
>> 
>>   /home/yoctocell/src/guix/gnu/packages/web-browsers.scm:911:13: av-98@1.0.1: can be upgraded to 8.0.3
>> 
>> That’s probably something that should be fixed with the PyPi importer,
>> though.
>> 
>> > +       (sha256
>> > +        (base32
>> > +         "02fjnc2rvm010gb3i07p8r4xlhrmnv1wca1qymfjcymr7vm68h0i"))))
>> > +    (build-system python-build-system)
>> > +    (home-page
>> > +     "https://tildegit.org/solderpunk/AV-98/")
>> 
>> No need for a newline.  :-)
>> 
>> > +    (synopsis "Command line Gemini client")
>> > +    (description "Command line Gemini client.")
>> 
>> The descrption should consist of one or more complete sentences,  see
>> “16.4.4 Synopses and Descriptions” in the manual for more details.  I
>> suggest (based on the README):
>> 
>>   AV-98 is an experimental client for the Gemini protocol.  Features
>>   include
>> 
>>   @itemize
>>   @item TOFU or CA server certificate validation;
>>   @item Extensive client certificate support if an openssl binary is available;
>>   @item Ability to specify external handler programs for different MIME types;
>>   @item Gopher proxy support;
>>   @item Advanced navigation tools like tour and mark (as per VF-1);
>>   @item Bookmarks;
>>   @item IPv6 support;
>>   @item Support for any character encoding recognised by Python.
>>   @end itemize
>> 
>> Otherwise, builds fine and LGTM!
>> 
>> [1]: <https://pypi.org/project/av/>
> From 561cdb35e69226c4c86fa611863f6abb82216011 Mon Sep 17 00:00:00 2001
> From: Christopher Howard <christopher@librehacker.com>
> Date: Fri, 10 Sep 2021 05:07:46 -0800
> Subject: [PATCH] gnu: Add av-98
>
> * gnu/packages/web-browsers.scm (av-98): New variable.
> ---
>  gnu/packages/web-browsers.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index be4fa61a37..cda9dee32f 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -19,6 +19,7 @@
>  ;;; Copyright © 2021 Benoit Joly <benoit@benoitj.ca>
>  ;;; Copyright © 2021 Alexander Krotov <krotov@iitp.ru>
>  ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
> +;;; Copyright © 2021 Christopher Howard <christopher@librehacker.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -903,3 +904,31 @@ interface.")
>      (synopsis "Gemini client with a terminal interface")
>      (description "Telescope is a w3m-like browser for Gemini.")
>      (license license:x11)))
> +
> +(define-public av-98
> +  (package
> +    (name "av-98")
> +    (version "1.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "AV-98" version))
> +       (sha256
> +        (base32
> +         "02fjnc2rvm010gb3i07p8r4xlhrmnv1wca1qymfjcymr7vm68h0i"))))
> +    (build-system python-build-system)
> +    (home-page "https://tildegit.org/solderpunk/AV-98/")
> +    (synopsis "Command line Gemini client")
> +    (description "AV-98 is an experimental client for the Gemini protocol.
> +Features include
> +@itemize
> +@item TOFU or CA server certificate validation;
> +@item Extensive client certificate support if an openssl binary is available;
> +@item Ability to specify external handler programs for different MIME types;
> +@item Gopher proxy support;
> +@item Advanced navigation tools like tour and mark (as per VF-1);
> +@item Bookmarks;
> +@item IPv6 support;
> +@item Support for any character encoding recognised by Python.
> +@end itemize")
> +    (license license:bsd-2)))
> -- 
> 2.33.0

LGTM, but I don’t have commit access, so someone else will have to merge
it.  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]