From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eepMH64IW2GwTgAAgWs5BA (envelope-from ) for ; Mon, 04 Oct 2021 15:59:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OIxTGq4IW2EydgAAB5/wlQ (envelope-from ) for ; Mon, 04 Oct 2021 13:59:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1762F278D1 for ; Mon, 4 Oct 2021 15:59:10 +0200 (CEST) Received: from localhost ([::1]:40492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXOUn-0000C4-8q for larch@yhetil.org; Mon, 04 Oct 2021 09:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXOUg-0000BZ-Qk for guix-patches@gnu.org; Mon, 04 Oct 2021 09:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXOUg-0008Jp-J0 for guix-patches@gnu.org; Mon, 04 Oct 2021 09:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXOUg-0004eR-F1 for guix-patches@gnu.org; Mon, 04 Oct 2021 09:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50967] [PATCH 00/12] Move (gnu home-services XYZ) to (gnu services XYZ) Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Oct 2021 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50967 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Oleg Pykhalov Cc: 50967@debbugs.gnu.org, Andrew Tropin Received: via spool by 50967-submit@debbugs.gnu.org id=B50967.163335592417843 (code B ref 50967); Mon, 04 Oct 2021 13:59:02 +0000 Received: (at 50967) by debbugs.gnu.org; 4 Oct 2021 13:58:44 +0000 Received: from localhost ([127.0.0.1]:37951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXOUI-0004dc-Gr for submit@debbugs.gnu.org; Mon, 04 Oct 2021 09:58:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXOUG-0004dI-7a for 50967@debbugs.gnu.org; Mon, 04 Oct 2021 09:58:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54804) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXOUA-0007r5-RV; Mon, 04 Oct 2021 09:58:30 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60550 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXOUA-0007l0-2d; Mon, 04 Oct 2021 09:58:30 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211002134352.5735-1-go.wigust@gmail.com> <20211002163834.29583-1-go.wigust@gmail.com> Date: Mon, 04 Oct 2021 15:58:28 +0200 In-Reply-To: <20211002163834.29583-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sat, 2 Oct 2021 19:38:21 +0300") Message-ID: <87h7dwq4cb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633355950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=0zK+igWA1V3qBc9DEA40VmXSGHw1L7ncn3WOzxwWasA=; b=sLvnBDUFJb3PRNuUzGnSLJ96K/pm3D4dpENXEwALytqeY/4xumyIOOPcOp/4oJET9+LYd2 vZgdxslv9HOC0h2AIC4rU2OgBinD2xEWaId9UmkQktVxn9wErydZK7EO40/1JaQ0HWpsT6 Yd/Qj2/4TBAYpig9xEj9jt9Pgr2b9Z/rbnRzc3NN6zxw0pQl7HWB+jlDp0BBuxNLPEKTuE xUSNpaj7ezRRTT8XIntIrjbWYPyHFtWdGbLbkCg5BtCco5YpB4/OQolwrJ/Wko9ndu20Qi p6FPk2fAwWdXVwHN8ECAHPvdh3VDfjeGUp2f5DRWSQ3esvq+bb5nftYLrSvQUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633355950; a=rsa-sha256; cv=none; b=uyfJpRdYtm4TKnZ9oApC/cR9qi567i55uMhighOGjJDPZloIWLRR1RyQ2D1IOPe5cXkYiE 0jEmlWTTxobuBlm/r3NwCCRs0BxMYfXkYiT9sWJ+7FRpl1FXeAyPlTdTa9AYwqdQYnSmw1 desC+jRY3YizOn82h/r0Uukp28V8wMfJtuZIZcYZuLVOvfWGo7wd31uQU3CVFmaPpfIAcY iNHqF8jR/ZUCXrhGv9lWTP94hpU2A4qXZF2dDUAWSN9lNbAk+ZZD9yE4SnROEcfgIgKe6n o55S+B8R1P4C6T67DiHIFUka142NTBLfLm4pD+AvL+2ZfLTklY7cB6pT71GPGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1762F278D1 X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: PTtwaUdz1L8U Hi Oleg, Oleg Pykhalov skribis: > From: Andrew Tropin > > * tests/guix-home.sh: New file. > * Makefile.am (SH_TESTS): Add tests/guix-home.sh. > > Signed-off-by: Oleg Pykhalov [...] > +# Reporting of syntax errors. > + > +cat > "$tmpfile"< +;; This is line 1, and the next one is line 2. > + (home-environment > + (packages)) > +;; The 'T' is at column 3. > +EOF This test is more or less copied from guix-system.sh, and I think it=E2=80= =99s not that useful because it=E2=80=99s testing the exact same functionality. Would it be possible to have a CLI test that really tests =E2=80=98guix hom= e=E2=80=99 functionality? The difficulty is that this would tend to rebuild the world. This can be worked around in one of two ways: 1. Add a =E2=80=98--bootstrap=E2=80=99 flag for force the use of the =E2= =80=9Cguile-bootstrap=E2=80=9D package instead of =E2=80=9Cguile=E2=80=9D, for instance, as is done f= or tests/guix-package.sh. 2. Run tests only when a =E2=80=9Creal=E2=80=9D daemon is available, usin= g it instead of the test daemon, as is done in tests/guix-pack-relocatable.sh. 3. Run tests in a VM using the (gnu tests =E2=80=A6) infrastructure. I don=E2=80=99t think #1 would work well for Guix Home. #2 is the easiest;= the downside is that tests would only be run on developer machines, not in CI. #3 is the most flexible approach, but the downside is that it=E2=80=99s more resource-intensive (needs to build a VM image, etc.). Overall, I=E2=80=99d recommend starting with #2 and eventually add tests as= #3, as far as integration tests are concerned. Then again, it=E2=80=99s also possible to have focused unit tests for speci= fic pieces, just like we have tests/union.scm for instance. WDYT? Thanks, Ludo=E2=80=99.