unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Kehayias via Guix-patches via <guix-patches@gnu.org>
Cc: John Kehayias <john.kehayias@pm.me>,
	"52803@debbugs.gnu.org" <52803-done@debbugs.gnu.org>
Subject: bug#52803: [PATCH v2] gnu: Add headsetcontrol.
Date: Mon, 27 Dec 2021 10:49:57 +0100	[thread overview]
Message-ID: <87h7au9y2i.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <2_c_qvqxrYLkzqE6Wi-swccI8XaI8F5g_J3nkn7XQ0WzTLUezJLbflel0dROLPJGoOHkShwG63WMQBGTiloR9XVKFSALj8cB9LNxtKZzt2M=@pm.me> (John Kehayias via Guix-patches via's message of "Sun, 26 Dec 2021 16:41:16 +0000")

Hello,

John Kehayias via Guix-patches via <guix-patches@gnu.org> writes:

> Subject: [PATCH] gnu: Add headsetcontrol.
>
> * gnu/packages/hardware.scm (headsetcontrol): New variable.

Thank you. I pushed it with the changes detailed below.

> +(define-public headsetcontrol
> +  (package
> +    (name "headsetcontrol")
> +    (version "2.6")
> +    (source (origin
> +             (method git-fetch)

I moved `origin' below `source' and adjusted indentation.

> +             (uri (git-reference
> +                   (url "https://github.com/Sapd/HeadsetControl")
> +                   (commit version)))
> +             (file-name (git-file-name name version))
> +             (sha256
> +              (base32
> +               "0a7zimzi71416pmn6z0l1dn1c2x8p702hkd0k6da9rsznff85a88"))))

I moved hash on the same line as `base32'

> +    (build-system cmake-build-system)
> +    (inputs
> +      (list hidapi))
> +    (synopsis "Sidetone and Battery status for USB headsets")
> +    (description
> +      "A tool to control certain aspects of USB-connected headsets on Linux.

I started the description with the name of the package (guix lint
should warn you about this), and removed reference to Linux, since it is
not useful in Guix.

> +Currently, support is provided for adjusting sidetone, getting battery state,
> +controlling LEDs, and setting the inactive time.")
> +    (home-page "https://github.com/Sapd/HeadsetControl")
> +    (license license:gpl3)))

I used gpl3+ as "main.c" includes "or (at your option) any later
version" in its header.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-12-27  9:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26 16:16 [bug#52803] [PATCH] gnu: Add headsetcontrol John Kehayias via Guix-patches via
2021-12-26 16:41 ` [bug#52803] [PATCH v2] " John Kehayias via Guix-patches via
2021-12-27  9:49   ` Nicolas Goaziou [this message]
2021-12-27 15:07     ` John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7au9y2i.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=52803-done@debbugs.gnu.org \
    --cc=guix-patches@gnu.org \
    --cc=john.kehayias@pm.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).