From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IEGSKhPG1mHyKQAAgWs5BA (envelope-from ) for ; Thu, 06 Jan 2022 11:36:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UJ8QKBPG1mGXAAAA9RJhRA (envelope-from ) for ; Thu, 06 Jan 2022 11:36:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A95215AFA for ; Thu, 6 Jan 2022 11:36:03 +0100 (CET) Received: from localhost ([::1]:35908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Q7m-0008N6-5j for larch@yhetil.org; Thu, 06 Jan 2022 05:36:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PmU-0004BX-1u for guix-patches@gnu.org; Thu, 06 Jan 2022 05:14:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5PmT-0005rh-OA for guix-patches@gnu.org; Thu, 06 Jan 2022 05:14:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5PmT-00025m-HT for guix-patches@gnu.org; Thu, 06 Jan 2022 05:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Jan 2022 10:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Sarah Morgensen , 50072@debbugs.gnu.org, zimoun Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.16414640288016 (code B ref 50072); Thu, 06 Jan 2022 10:14:01 +0000 Received: (at 50072) by debbugs.gnu.org; 6 Jan 2022 10:13:48 +0000 Received: from localhost ([127.0.0.1]:39702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PmF-00025E-OU for submit@debbugs.gnu.org; Thu, 06 Jan 2022 05:13:47 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:58722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PmE-000250-8D for 50072@debbugs.gnu.org; Thu, 06 Jan 2022 05:13:46 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AECEC2C3; Thu, 6 Jan 2022 11:13:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ngv4ikgwO8gQ; Thu, 6 Jan 2022 11:13:38 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 3624D1D7; Thu, 6 Jan 2022 11:13:38 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220104200643.43374-1-maximedevos@telenet.be> <20220104200643.43374-2-maximedevos@telenet.be> <867dbfcf9n.fsf_-_@gmail.com> <52e7be94d926aa06c2a0132090e8c212381e7900.camel@telenet.be> <86y23u768v.fsf@gmail.com> <86pmp6730h.fsf@gmail.com> <6fcbe52781b0678ea44db9beea2e1bd3f404b840.camel@telenet.be> Date: Thu, 06 Jan 2022 11:13:37 +0100 In-Reply-To: <6fcbe52781b0678ea44db9beea2e1bd3f404b840.camel@telenet.be> (Maxime Devos's message of "Wed, 05 Jan 2022 14:06:55 +0000") Message-ID: <87h7ahf9ym.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: + X-Rspamd-Server: hera X-Rspamd-Queue-Id: AECEC2C3 X-Spamd-Result: default: False [1.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,mgsn.dev,debbugs.gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641465363; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=+RW88Slj5JljZaLEl9ADb3ScGkz8WCdqTInWsJjnzWA=; b=B3MXXF2Dn7ua++8iXcy7IDZ7bHZ4jev+hac/adDq43611LndypSc212djXhUDpTKaFEMqJ MxChjMPzJHF234jFoMZ6aZLWdkT43tiXRiXQpxGCBHM863gKWEbGCClbJ7ANPTDmjYDXwC P8qNyQS6ZInsU9l4IyJPkm++5jv5U5MfgtVje1KLHRNpOzHBuxl1myM6/E2fkaCAulYz+h mc5XN90Yac3V0a3d9fSb2ljqAhs0VBWvMGbUUE2yCFPFXSjkwy1d7G4JBnRY6XtuKYTw2x l6e3C6AmFHX5A4G8Bep4XHgs95OEf5dCY5/m28b44wTNwaC+OAFnpCDrLY15ag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641465363; a=rsa-sha256; cv=none; b=PD0+tdkPBSp4SiXOHwLagkEwm36pBTkjr7MpUSSuz8QNOyvGlq+ZsxqfbPTY0VCvN8u2Aa kf0sW7vqRReY2dLu+VjMMDRLHtM+bEuHxSHe4DRcvJEvcWaSP9+p0pCAmviRzL6Atk6GNA RgWuB/WQJUa9AM9s4nCNFpv+OOApI131DfclckertgC1uam8sRw0cFMoCsgNP2wzcv/oES N/SA09mfmKOsm9BOhr4ZXXiwTU8Qe2h0waqmz379LwIdoHIqwykzQeacyMrfrF4flzOlLI O/A8eTaa7PgCRbwVaZP6DZz4gnVOPE8NEROTw9tOcydjWpSlm4zBrjZzdhD0YA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7A95215AFA X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2rdYkPJhytLH Maxime Devos skribis: > zimoun schreef op wo 05-01-2022 om 13:58 [+0100]: [...] >> =C2=A02) From my point of view, =E2=80=99#:recursive?=E2=80=99 needs to = be adapted in >> =C2=A0agreement with the discussion [1], quoting Ludo: >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Thinking more about it, = I think confusion stems from the term >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=E2=80=9Crecursive=E2=80= =9D (inherited from Nix) because, as you write, it >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0doesn=E2=80=99t necessar= ily have to do with recursion and directory >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0traversal. >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Instead, it has to do wi= th the serialization method. >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01: >>=20 >> =C2=A0=C2=A0=C2=A0And I do not have a strong opinion. Just a naive rema= rk. > > I don't think the arguments for (guix scripts hash) apply directly > to (guix hash) -- (guix scripts hash) supports multiple serialisers: > > * none (regular in (guix hash) terminology) > * git > * nar > * swh I think IWBN eventually for =E2=80=98file-hash*=E2=80=99 to have a #:serial= izer argument. (guix scripts hash) would then become a thin layer above (guix hash). That #:serializer would have a default value, probably =E2=80=9Cnone=E2=80= =9D, but no =E2=80=9Cauto-detection=E2=80=9D as this amount of guessing would make for = a fragile interface IMO. (Perhaps =E2=80=98file-hash=E2=80=99 is too generic-sounding; for a =E2=80= =98source-code-hash=E2=80=99 or similarly-named procedure, some defaults and guesswork would be more obvious.) Thanks, Ludo=E2=80=99.