[bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.

[bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.

[Leo Famulari]

This package doesn't build anymore:

https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+luminance-hdr

* gnu/packages/image-viewers.scm (luminance-hdr): Remove variable.
---
 gnu/packages/image-viewers.scm | 63 ----------------------------------
 1 file changed, 63 deletions(-)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index b61a79370d..68d9e53bf2 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -588,69 +588,6 @@ (define-public catimg
 It supports JPEG, PNG and GIF formats.")
     (license license:expat)))
 
-(define-public luminance-hdr
-  (package
-    (name "luminance-hdr")
-    (version "2.6.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "mirror://sourceforge/qtpfsgui/luminance/"
-                    version "/luminance-hdr-" version ".tar.bz2"))
-              (sha256
-               (base32
-                "188q0l63nfasqfvwbq4mwx2vh7wsfi2bq9n5nksddspl1qz01lnp"))))
-    (build-system cmake-build-system)
-    (native-inputs
-     (list pkg-config qttools))
-    (inputs
-     `(("qtbase" ,qtbase-5)
-       ("qtdeclarative" ,qtdeclarative)
-       ("qtsvg" ,qtsvg)
-       ("qtwebkit" ,qtwebkit)
-       ("boost" ,boost)
-       ("eigen" ,eigen)
-       ;; ("gtest" ,gtest)
-       ("libraw" ,libraw)
-       ("zlib" ,zlib)
-       ("exiv2" ,exiv2)
-       ("libpng" ,libpng)
-       ("libjpeg" ,libjpeg-turbo)
-       ("lcms" ,lcms)
-       ("openexr" ,openexr-2)
-       ("fftw" ,fftwf)
-       ("gsl" ,gsl)
-       ("libtiff" ,libtiff)))
-    (arguments
-     '(#:tests? #f  ;XXX: some tests fail to compile
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'set-paths 'add-ilmbase-include-path
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; 'OpenEXR.pc' has a -I for IlmBase but 'FindOpenEXR.cmake' does
-             ;; not use 'OpenEXR.pc'.  Thus, we need to add
-             ;; "$ilmbase/include/OpenEXR/" to the CPATH.
-             (setenv "CPATH"
-                     (string-append
-                      (search-input-directory inputs "include/OpenEXR")
-                      ":" (or (getenv "CPATH") ""))))))))
-    (home-page "http://qtpfsgui.sourceforge.net")
-    (synopsis "High dynamic range (HDR) imaging application")
-    (description
-     "Luminance HDR (formerly QtPFSGui) is a graphical user interface
-application that aims to provide a workflow for high dynamic range (HDR)
-imaging.  It supports several HDR and LDR image formats, and it can:
-
-@itemize
-@item Create an HDR file from a set of images (formats: JPEG, TIFF 8bit and
-16bit, RAW) of the same scene taken at different exposure setting;
-@item Save load HDR images;
-@item Rotate, resize and crop HDR images;
-@item Tone-map HDR images;
-@item Copy EXIF data between sets of images.
-@end itemize\n")
-    (license license:gpl2+)))
-
 ;; CBR and RAR are currently unsupported, due to non-free dependencies.
 (define-public mcomix
   ;; Official mcomix hasn't been updated since 2016, it's broken with
-- 
2.34.0

[bug#53557] [PATCH 2/2] gnu: Remove aseba.

[Leo Famulari]

This package doesn't build anymore:

https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+aseba

* gnu/packages/robotics.scm (aseba): Remove variable.
---
 gnu/packages/robotics.scm | 67 ++-------------------------------------
 1 file changed, 3 insertions(+), 64 deletions(-)

diff --git a/gnu/packages/robotics.scm b/gnu/packages/robotics.scm
index a110d0e6bd..9d7e2bf4c4 100644
--- a/gnu/packages/robotics.scm
+++ b/gnu/packages/robotics.scm
@@ -18,20 +18,13 @@
 
 (define-module (gnu packages robotics)
   #:use-module (guix packages)
-  #:use-module (guix download)
   #:use-module (guix git-download)
-  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix licenses)
   #:use-module (guix build-system cmake)
-  #:use-module (gnu packages avahi)
-  #:use-module (gnu packages cpp)
   #:use-module (gnu packages gl)
-  #:use-module (gnu packages linux)
   #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages protobuf)
-  #:use-module (gnu packages qt)
   #:use-module (gnu packages sdl)
-  #:use-module (gnu packages valgrind)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages qt))
 
 (define-public enki
   ;; Previous versions use Qt4 and are unsuitable for Aseba.
@@ -70,58 +63,4 @@ (define-public enki
       ;; researchers using the software are "asked" to cite using a given
       ;; citation, but that sentence is written as not being part of the
       ;; license (fortunately).
-      (license license:gpl2+))))
-
-(define-public aseba
-  ;; Use the commit that allows us to build with Qt5.
-  (let ((commit "3b35de80d5fdd47592b1c01d57e1f4ef37c5e5ea")
-        (revision "0"))
-    (package
-      (name "aseba")
-      (version (git-version "1.6.0" revision commit))
-      (home-page "https://github.com/aseba-community/aseba")
-      (source (origin
-                (method git-fetch)
-                (uri (git-reference (url home-page) (commit commit)
-                                    (recursive? #t))) ;for Blockly
-                (sha256
-                 (base32
-                  "0j31lmc9f0ksvkh0md2fgsz92hcsrwnrqqcynamizs2ah8iwlqi5"))
-                (file-name (string-append name "-" version "-checkout"))
-                (modules '((guix build utils)))
-                (snippet
-                 ;; Add missing Qt5::Network.
-                 '(begin
-                    (substitute* "targets/playground/CMakeLists.txt"
-                      (("target_link_libraries(.*)\\$\\{EXTRA_LIBS\\}" _ middle)
-                       (string-append "target_link_libraries" middle
-                                      " Qt5::Network ${EXTRA_LIBS}")))
-                    #t))))
-      (build-system cmake-build-system)
-      (arguments
-       '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
-      (native-inputs
-       (list pkg-config valgrind))                 ;for tests
-      (inputs
-       (list dashel
-             enki
-             protobuf-3.5 ;for logging
-             qtbase-5
-             qtsvg
-             qttools ;for libQt5Help, needed by "studio"
-             qtwebkit
-             qtx11extras
-             eudev
-             libxml2
-             sdl2
-             avahi))            ;XXX: we need the libdnssd compat layer
-      (synopsis "Event-based robot programming tools")
-      (description
-       "Aseba means @dfn{actuator and sensor event-based architecture}.
-It is a set of tools which allow beginners to program robots easily and
-efficiently.  It includes robot simulators, a programming language, and a
-visual programming language (VPL) that is notably used together with the
-Thymio educational robot.")
-
-      ;; Source file headers say "version 3.0" without "or any later version".
-      (license license:lgpl3))))
+      (license gpl2+))))
-- 
2.34.0

[bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.

[Maxim Cournoyer]

Hello Leo,

Leo Famulari <leo@famulari.name> writes:

> This package doesn't build anymore:
>
> https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+luminance-hdr
>
> * gnu/packages/image-viewers.scm (luminance-hdr): Remove variable.
> ---
>  gnu/packages/image-viewers.scm | 63 ----------------------------------
>  1 file changed, 63 deletions(-)

As I mentioned on #guix, I don't think removing broken but still
actively developed packages is the way to go.  Have you opened an issue
with upstream about the build failure?  I've searched but haven't seen
it.  Development now happens here:
https://github.com/LuminanceHDR/LuminanceHDR/

Other distributions are offering the package; we should check how they
do it.

At any rate, I don't think we should remove broken packages just because
they happen to be broken now.  It seems your concern was to advertise
broken packages to our users?  If so the way to do that would be to plug
the CI results in the generated package list on our site (they could be
shown in red or something).

Thanks,

Maxim

[bug#53557] [PATCH 2/2] gnu: Remove aseba.

[Maxim Cournoyer]

+CC Ludo, who originally added the package

Hi Leo!

Leo Famulari <leo@famulari.name> writes:

> This package doesn't build anymore:
>
> https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+aseba
>
> * gnu/packages/robotics.scm (aseba): Remove variable.
> ---
>  gnu/packages/robotics.scm | 67 ++-------------------------------------
>  1 file changed, 3 insertions(+), 64 deletions(-)
>
> diff --git a/gnu/packages/robotics.scm b/gnu/packages/robotics.scm
> index a110d0e6bd..9d7e2bf4c4 100644
> --- a/gnu/packages/robotics.scm
> +++ b/gnu/packages/robotics.scm
> @@ -18,20 +18,13 @@
>  
>  (define-module (gnu packages robotics)
>    #:use-module (guix packages)
> -  #:use-module (guix download)
>    #:use-module (guix git-download)
> -  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix licenses)
>    #:use-module (guix build-system cmake)
> -  #:use-module (gnu packages avahi)
> -  #:use-module (gnu packages cpp)
>    #:use-module (gnu packages gl)
> -  #:use-module (gnu packages linux)
>    #:use-module (gnu packages pkg-config)
> -  #:use-module (gnu packages protobuf)
> -  #:use-module (gnu packages qt)
>    #:use-module (gnu packages sdl)
> -  #:use-module (gnu packages valgrind)
> -  #:use-module (gnu packages xml))
> +  #:use-module (gnu packages qt))
>  
>  (define-public enki
>    ;; Previous versions use Qt4 and are unsuitable for Aseba.
> @@ -70,58 +63,4 @@ (define-public enki
>        ;; researchers using the software are "asked" to cite using a given
>        ;; citation, but that sentence is written as not being part of the
>        ;; license (fortunately).
> -      (license license:gpl2+))))
> -
> -(define-public aseba
> -  ;; Use the commit that allows us to build with Qt5.
> -  (let ((commit "3b35de80d5fdd47592b1c01d57e1f4ef37c5e5ea")
> -        (revision "0"))
> -    (package
> -      (name "aseba")
> -      (version (git-version "1.6.0" revision commit))
> -      (home-page "https://github.com/aseba-community/aseba")
> -      (source (origin
> -                (method git-fetch)
> -                (uri (git-reference (url home-page) (commit commit)
> -                                    (recursive? #t))) ;for Blockly
> -                (sha256
> -                 (base32
> -                  "0j31lmc9f0ksvkh0md2fgsz92hcsrwnrqqcynamizs2ah8iwlqi5"))
> -                (file-name (string-append name "-" version "-checkout"))
> -                (modules '((guix build utils)))
> -                (snippet
> -                 ;; Add missing Qt5::Network.
> -                 '(begin
> -                    (substitute* "targets/playground/CMakeLists.txt"
> -                      (("target_link_libraries(.*)\\$\\{EXTRA_LIBS\\}" _ middle)
> -                       (string-append "target_link_libraries" middle
> -                                      " Qt5::Network ${EXTRA_LIBS}")))
> -                    #t))))
> -      (build-system cmake-build-system)
> -      (arguments
> -       '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
> -      (native-inputs
> -       (list pkg-config valgrind))                 ;for tests
> -      (inputs
> -       (list dashel
> -             enki
> -             protobuf-3.5 ;for logging
> -             qtbase-5
> -             qtsvg
> -             qttools ;for libQt5Help, needed by "studio"
> -             qtwebkit
> -             qtx11extras
> -             eudev
> -             libxml2
> -             sdl2
> -             avahi))            ;XXX: we need the libdnssd compat layer
> -      (synopsis "Event-based robot programming tools")
> -      (description
> -       "Aseba means @dfn{actuator and sensor event-based architecture}.
> -It is a set of tools which allow beginners to program robots easily and
> -efficiently.  It includes robot simulators, a programming language, and a
> -visual programming language (VPL) that is notably used together with the
> -Thymio educational robot.")
> -
> -      ;; Source file headers say "version 3.0" without "or any later version".
> -      (license license:lgpl3))))
> +      (license gpl2+))))

I'm not sure about this one.  Pinging Ludo, who originally added it; it
seems to be perhaps related to the work of colleagues at the INRIA.

Thank you,

Maxim

[bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.

[Leo Famulari]

On Wed, Jan 26, 2022 at 11:32:57PM -0500, Maxim Cournoyer wrote:
> As I mentioned on #guix, I don't think removing broken but still
> actively developed packages is the way to go.  Have you opened an issue
> with upstream about the build failure?  I've searched but haven't seen
> it.  Development now happens here:
> https://github.com/LuminanceHDR/LuminanceHDR/

I think that asking upstream is something that can be done by people who
aim to use this package. The packages have to sustain themselves with
user contributions: this work can't be done by just a handful of us.

Since this package hasn't built in a couple months (at least; that's as
far back as ci.guix.gnu.org shows us), one could guess it has no users.
A question of the chicken and the egg, perhaps, but we need a whole
henhouse regardless.

Additionally, this package depends on QtWebKit, which I am working to
remove from the distro:

https://issues.guix.gnu.org/53289

I respectfully insist that we wait 2 weeks for patches to fix this
package or else remove it from Guix.

[bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.

[Liliana Marie Prikler]

Hi Leo,

Am Donnerstag, dem 27.01.2022 um 01:10 -0500 schrieb Leo Famulari:
> Additionally, this package depends on QtWebKit, which I am working to
> remove from the distro:
> 
> https://issues.guix.gnu.org/53289
The package can optionally build against QtWebEngine as of version
2.6.1 [1] (which for some odd reason is not advertised as latest on
either Github or Sourceforge).  Sourceforge has a tarball for both that
[2] and 2.6.1.1 [3].  So rather than dropping it, we should version-
bump it.  Other distros already ship it, including Debian experimental
and Fedora 33+ [4].

Cheers

[1] 
https://github.com/LuminanceHDR/LuminanceHDR/blob/v.2.6.1/CMakeLists.txt
[2] https://sourceforge.net/projects/qtpfsgui/files/luminance/2.6.1/
[3] https://sourceforge.net/projects/qtpfsgui/files/luminance/2.6.1.1/
[4] https://repology.org/project/luminance-hdr/versions

[bug#53556] [PATCH 1/2] gnu: Remove luminance-hdr.

[Leo Famulari]

On Thu, Jan 27, 2022 at 08:14:32AM +0100, Liliana Marie Prikler wrote:
> The package can optionally build against QtWebEngine as of version
> 2.6.1 [1] (which for some odd reason is not advertised as latest on
> either Github or Sourceforge).  Sourceforge has a tarball for both that
> [2] and 2.6.1.1 [3].  So rather than dropping it, we should version-
> bump it.  Other distros already ship it, including Debian experimental
> and Fedora 33+ [4].

Sure, somebody can upgrade it and change the dependencies if they want.

bug#53557: [PATCH 2/2] gnu: Remove aseba.

[Ludovic Courtès]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> This package doesn't build anymore:
>>
>> https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+aseba
>>
>> * gnu/packages/robotics.scm (aseba): Remove variable.

I’ve instead fixed it in f4554d28d6764aa8a733e4147dff8e8d473be19e.

Thanks for the heads-up!

Ludo’.