unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>, "Leo Famulari" <leo@famulari.name>
Cc: 53295-done@debbugs.gnu.org
Subject: bug#53295: [PATCH] gnu: Add FFmpeg 5.0.
Date: Mon, 23 May 2022 19:58:46 +0200	[thread overview]
Message-ID: <87h75g2krt.fsf@gnu.org> (raw)
In-Reply-To: <87pmohwkp5.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

Ludovic Courtès <ludo@gnu.org> skriver:

> Hi,
>
> Leo Famulari <leo@famulari.name> skribis:
>
>> Here's the new major release of FFmpeg.
>>
>> We can add it right away and move users over to it incrementally as we
>> test them — having this new version is useful for people like me who use
>> FFmpeg directly.
>>
>> Also, I always found our FFmpeg packages' use of inheritance to be
>> confusing when making changes to them, so I didn't use it here.
>>
>> * gnu/packages/video.scm (ffmpeg-5): New variable.
>
> Could you remove input labels?  (I think ‘guix style’ can’t help because
> of the conditional in the middle.)
>
> That said, it seems to me there’s a lot of duplication here compared to
> version 4.  So I’d be in favor of inheriting from that one.

I went ahead and pushed this patch in 1cb10f696813ef23678029, with the
adjustments Ludo recommended + G-expressions; as well as a follow-up
that makes ffmpeg@4 inherit from it.

Thanks Leo & Ludo!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-05-23 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-16  5:35 [bug#53295] [PATCH] gnu: Add FFmpeg 5.0 Leo Famulari
2022-01-24  9:24 ` Ludovic Courtès
2022-05-23 17:58   ` Marius Bakke [this message]
2022-05-24  1:03     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h75g2krt.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=53295-done@debbugs.gnu.org \
    --cc=leo@famulari.name \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).