unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: jgart <jgart@dismail.de>
Cc: 55896@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#55896] [PATCH] gnu: Add python-pybare.
Date: Thu, 07 Jul 2022 16:33:20 -0400	[thread overview]
Message-ID: <87h73swtm7.fsf_-_@gmail.com> (raw)
In-Reply-To: <20220612155418.GC1648@gac> (jgart@dismail.de's message of "Sun,  12 Jun 2022 15:54:18 -0500")

Hello,

jgart <jgart@dismail.de> writes:

[...]

> Hi Maxime, no worries. Take your time. The review is much appreciated.
>
> I just looked at the sources again myself and noticed that the tests
> use pre-generated BARE binaries to test against.
>
> See here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225
>
> and here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples
>
> Should I ask the author if they can provide a way to generate those
> binaries for testing instead of vendoring the pre-compiled binaries
> without their sources?

Yes, please ask.  Otherwise, we'll have to delete the binaries from
unknown source in a source snippet and not run the test suite...

Thank you!

Maxim




  reply	other threads:[~2022-07-07 20:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  4:27 [bug#55896] [PATCH] gnu: Add python-pybare jgart via Guix-patches via
2022-06-11  8:21 ` Maxime Devos
2022-06-11 20:27 ` [bug#55896] [PATCH v2] " jgart via Guix-patches via
2022-06-12 15:41   ` Maxime Devos
2022-06-12 20:54     ` jgart via Guix-patches via
2022-07-07 20:33       ` Maxim Cournoyer [this message]
2022-07-07 23:59         ` [bug#55896] [PATCH] " jgart via Guix-patches via
2024-06-18  6:07 ` bug#55896: jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h73swtm7.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=55896@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).