From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KPJ5L6CzKGP9HwEAbAwnHQ (envelope-from ) for ; Mon, 19 Sep 2022 20:23:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AO16LqCzKGN4ewEAG6o9tA (envelope-from ) for ; Mon, 19 Sep 2022 20:23:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77E69B6C7 for ; Mon, 19 Sep 2022 20:23:28 +0200 (CEST) Received: from localhost ([::1]:54368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaLQU-0001Na-KL for larch@yhetil.org; Mon, 19 Sep 2022 14:23:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaLQ6-0001K7-Hp for guix-patches@gnu.org; Mon, 19 Sep 2022 14:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaLQ6-00027D-9Z for guix-patches@gnu.org; Mon, 19 Sep 2022 14:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaLQ6-0004ZT-4m for guix-patches@gnu.org; Mon, 19 Sep 2022 14:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57757] [PATCH] gnu: Add sbcl-stumpwm-pamixer Resent-From: Trev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Sep 2022 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57757 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 57757@debbugs.gnu.org Received: via spool by 57757-submit@debbugs.gnu.org id=B57757.166361175117517 (code B ref 57757); Mon, 19 Sep 2022 18:23:02 +0000 Received: (at 57757) by debbugs.gnu.org; 19 Sep 2022 18:22:31 +0000 Received: from localhost ([127.0.0.1]:55173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaLPb-0004YS-7Z for submit@debbugs.gnu.org; Mon, 19 Sep 2022 14:22:31 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:44335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaLPY-0004YC-HG for 57757@debbugs.gnu.org; Mon, 19 Sep 2022 14:22:29 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 858F33200645; Mon, 19 Sep 2022 14:22:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 19 Sep 2022 14:22:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trevdev.ca; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1663611742; x=1663698142; bh=Wl2EGf2m39 pUb9rD0SzLNtaSnAxj6MjojUf0lX6sft4=; b=WM+KS1ix+/pL0EAVdsKOQEbOnB uOrZp1fLxSAMrwf/Roa932R+X0zvtV2NVu5SvIEoxzs4NNXe0WvMrKXwc974vWA0 xZ2L6798Zy6z0THq/EBok8n8zxzPdKRmGV5Ixmh4UCI4Kpv9UCAZQh47v2Kl9gsG TvsNF62bYiWqjo9pZwHKnoKW4iVOXRckzIdKLHcEhbScjQrX8EFUWxQM41qVDJ80 ZCDrjwK+IhE2mzFyVzlmvImpmUtJVxAvknegZp/gTHxebS8R2Td/Ko+H9afp/RhW XTjlba9L+TTGsj28hwtng2gVcjbTbM/rxugG3l94LSDaXG1rVtgmXB/xn7qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663611742; x=1663698142; bh=Wl2EGf2m39pUb9rD0SzLNtaSnAxj 6MjojUf0lX6sft4=; b=JRo8wFS7l2CrjTLYK6KQphu2xISoYii09aDytAEK7Dcq cw5GbVeflIkMClMqAZhr9bk5mFoYS6vHgIMGKgDKW7Vpfejett2cIxqtfN5f+d3A ZCapJadgESh4EMHDliIiOlFWKTuiNyfFefLUbzSbZtEzAhNB73JO4WX97xW42Fi9 5O86ynQVm2MWtZPbeeJNx9/GGwlHEwduof5ol6mjNk/yfRT8LaZwgABmsxhp4+ug yyKaJ6/cszQoB32CPPbQ00fdL1Ua7LX0nt1eNzlFxjXZUJs56/J3mb0KqHxJ7g5k LVO0Go/p4uK43QpeBrxeoJ6EJK60oweeZOh9caGniw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvjedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepvfhrvghv uceothhrvghvsehtrhgvvhguvghvrdgtrgeqnecuggftrfgrthhtvghrnhephfelffegue eikeefhfdttdffjeffleegvdevfeffheeugfdvjefftddvffeikeehnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhrvghvsehtrhgvvhguvg hvrdgtrg X-ME-Proxy: Feedback-ID: i762946f9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 14:22:21 -0400 (EDT) From: Trev In-Reply-To: References: User-Agent: Notmuch/0.36 (https://notmuchmail.org) Emacs/28.1 (x86_64-pc-linux-gnu) Date: Mon, 19 Sep 2022 11:22:20 -0700 Message-ID: <87h713jkbn.fsf@codinator.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663611808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Wl2EGf2m39pUb9rD0SzLNtaSnAxj6MjojUf0lX6sft4=; b=Et/g6ETVQcQKk7gYjHVe7XcKDV/z9tnBv29pRWtbkZesCuJR1knbffqdySJUmS2F455jim BoZjkq/XWmSdoc8R4eSkmMxCcHMtO4fMM2QqneXCxTaftp/lSX7fZWmGb/sy2fc8mQxBYq heMK93z6QTTZdElORXCaLAr/hZMej4ImZP0rOQmKVX+pFPrar7g8dHmJGMxS2YLgSUXsq4 7mXCCBzhRO4Ru1SaOIGqUPUpEeDMy45t+LipHV2o6u9YGVxzMv3ZWVNJtJV8O0naw+Avs7 x6Wq3LP3SF0simA4HX0+XygKjg6/CjVWGzy/QqCwT8e0RAYg7nb6YJ25soF0Fw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663611808; a=rsa-sha256; cv=none; b=kNEs8GutBtRdU8qxoJYh56nri44VizNgAiYXGpLrtwyOWIaNXzDxAy0gWgjqrSznOhMTsF NEk7FpibAqW/g8rsNpj3ZmG/J03MMTWgjKwG8l3Ka+lnVffbB3iO3WmbuxsYkz2SAePLLo IM+yh+8bjG3xWHYub0UiQp4C/cWMNR3IRfsG9oENKlNVq65DW6zcK2QKElYy78izzVNpbR /jWUG0C5Mh8E9bZ1++2sXHG70ZcdmihXCSnajEgtR5g1n3i8UZVRHYn/6KY2rlwik3GwkP GlXlZs6pOeUeoAQH7bXvi4K3CoN33AWU5n5bcWGuNS1xpRC3QOLw4FmdSOyOVA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trevdev.ca header.s=fm3 header.b=WM+KS1ix; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=JRo8wFS7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trevdev.ca header.s=fm3 header.b=WM+KS1ix; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=JRo8wFS7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 77E69B6C7 X-Spam-Score: 0.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: 9uSoRKag/4KE --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxime Devos writes: > On 19-09-2022 19:47, Trevor Richards wrote: >> + (arguments >> + `(#:asd-systems '(:pamixer) >> + #:phases >> + ,#~(modify-phases %standard-phases >> + (add-after 'unpack 'patch-pamixer >> + (lambda _ >> + (substitute* "pamixer.lisp" >> + (("\"pamixer \"") >> + (string-append >> + "\"" #$pamixer "/bin/pamixer \"")))))))) > > To support --with-input transformations, you can't do #$input, you have=20 > to do #$(this-package-input "pamixer") instead -- or better, don't=20 > depend on input labels, by using (search-input-file inputs=20 > "bin/pamixer") instead. > Thanks for the feedback. It's hard to tell when a gexp is appropriate and where it's not, or how to properly evaluate it all at the right time. The current patch builds. Is this problematic in the sense that it's using some reference to #$pamixer that is not actually a part of the build environment? Note I had to use a quasiqote and unquote for the `gexp` to work. Transforming the arguments into a list so I would not have to do this breaks the #:asd-systems keyword value somehow. When I observe the source code it's kinda all over the place when it comes to using gexps in some way or when not to. I will patch this again and document a note about this but if there's any clarifying documentation I would happily read it. Apologies in advance if I have missed existing documentation. =2D-=20 Trev : 0FB7 D06B 4A2A F07E AD5B 1169 183B 6306 8AA1 D206 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIYEARYIAC4WIQTXT7EGCbVt/Iwh9m+FRs+EoT3V7wUCYyizXBAcdHJldkB0cmV2 ZGV2LmNhAAoJEIVGz4ShPdXvNTEBAJXKHWWy5MT0/hj8aOukYauxqcSekkCJ0vb2 3J9Ty9MgAP92oj5fx2KVYvqI9AafuahyXZqKlwPYeu7f59BCf3p+BQ== =kOjI -----END PGP SIGNATURE----- --=-=-=--