From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: 58549@debbugs.gnu.org
Subject: [bug#58549] [PATCH draft] installer: welcome: Warn when uvesafb gets used.
Date: Sat, 15 Oct 2022 17:39:03 +0200 [thread overview]
Message-ID: <87h7055c6g.fsf@pelzflorian.de> (raw)
There will be false positives: Because the Guix installer uses the
kernel argument modprobe.blacklist=radeon,amdgpu and some AMD graphics
actually work okay according to h-node, these users will get a
false alarm.
* gnu/installer/newt/welcome.scm (run-welcome-page): Warn before showing
the welcome page.
---
gnu/installer/newt/welcome.scm | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gnu/installer/newt/welcome.scm b/gnu/installer/newt/welcome.scm
index 7a7ddfb7bd..762fca96eb 100644
--- a/gnu/installer/newt/welcome.scm
+++ b/gnu/installer/newt/welcome.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
;;; Copyright © 2020 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2022 Florian Pelz <pelzflorian@pelzflorian.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -17,6 +18,8 @@
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
(define-module (gnu installer newt welcome)
+ #:use-module ((gnu build linux-modules)
+ #:select (modules-loaded))
#:use-module (gnu installer steps)
#:use-module (gnu installer utils)
#:use-module (gnu installer newt page)
@@ -121,6 +124,14 @@ (define (run-welcome-page logo)
"Run a welcome page with the given textual LOGO displayed at the center of
the page. Ask the user to choose between manual installation, graphical
installation and reboot."
+ (begin
+ (when (member "uvesafb" (modules-loaded))
+ (run-error-page (G_ "\
+This may be a false alarm, but possibly your graphics hardware does not
+work well with only free software. Expect trouble. If after installation,
+the system does not boot, perhaps you will need to add nomodeset to the
+kernel arguments and need to configure the uvesafb kernel module.")
+ (G_ "Pre-install warning")))
(run-menu-page
(G_ "GNU Guix install")
(G_ "Welcome to GNU Guix system installer!
@@ -148,3 +159,4 @@ (define (run-welcome-page logo)
(newt-finish)
(reboot))))
#:listbox-item->text car))
+ )
base-commit: d923cf1deac0b6762345d0d9e53822cbcb899365
--
2.37.3
next reply other threads:[~2022-10-15 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 15:39 pelzflorian (Florian Pelz) [this message]
2022-10-15 15:47 ` [bug#58549] [PATCH draft] installer: welcome: Warn when uvesafb gets used pelzflorian (Florian Pelz)
2022-10-17 9:40 ` Mathieu Othacehe
2022-10-24 13:39 ` pelzflorian (Florian Pelz)
2022-10-24 14:20 ` Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7055c6g.fsf@pelzflorian.de \
--to=pelzflorian@pelzflorian.de \
--cc=58549@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).