unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 58660@debbugs.gnu.org
Subject: [bug#58660] [PATCH v2 1/3] etc: teams: Add 'show' subcommand.
Date: Mon, 21 Nov 2022 17:00:52 +0100	[thread overview]
Message-ID: <87h6yswb4b.fsf@gmail.com> (raw)
In-Reply-To: <87bkp4f9wx.fsf@gnu.org>

Hi Mathieu,

On Fri, 18 Nov 2022 at 18:29, Mathieu Othacehe <othacehe@gnu.org> wrote:

> This procedure is starting to get a little complex. We could put the
> above is a sub-procedure called "print-team".

I will try to revamp for a v3.

>> +       (sort
>> +        (hash-map->list (lambda (key value) value) %teams)
>> +        (lambda (team1 team2)
>> +          (string<? (symbol->string (team-id team1))
>> +                    (symbol->string (team-id team2))))))))
>
> That could be in a variable called %sorted-teams.

This had been introduced by 18fb7c0f3078216bf4fc865d86b3be76ddc68414.
Indeed, it could be extracted; part of the revamp.


Cheers,
simon




      reply	other threads:[~2022-11-21 16:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221020132140.1546684-1-zimon.toutoune@gmail.com>
2022-10-20 13:28 ` [bug#58660] [PATCH 1/4] etc: teams: Improve scope display zimoun
2022-10-20 13:28   ` [bug#58660] [PATCH 3/4] etc: teams: List teams sorted by id zimoun
2022-10-20 13:28   ` [bug#58660] [PATCH 4/4] etc: teams: Display an id number zimoun
2022-11-05 12:18   ` [bug#58660] [PATCH 1/4] etc: teams: Improve scope display ( via Guix-patches via
2022-11-05 13:09     ` zimoun
2022-11-05 13:29       ` ( via Guix-patches via
2022-11-04 10:11 ` [bug#58660] [PATCH 0/4] Minor tweaks of etc/teams.scm zimoun
2022-11-09 16:23 ` Mathieu Othacehe
2022-11-17 20:27   ` zimoun
2022-11-18 17:31     ` Mathieu Othacehe
2022-11-17 20:28 ` [bug#58660] [PATCH v2 1/3] etc: teams: Add 'show' subcommand zimoun
2022-11-17 20:28   ` [bug#58660] [PATCH v2 2/3] etc: teams: Sort and itemize 'scope' field zimoun
2022-11-18 17:23     ` Mathieu Othacehe
2022-11-21 14:11       ` zimoun
2023-08-29 18:58         ` bug#58660: [PATCH 0/4] Minor tweaks of etc/teams.scm Maxim Cournoyer
2022-11-17 20:28   ` [bug#58660] [PATCH v2 3/3] etc: teams: Improve display of regular expression in 'scope' field zimoun
2022-11-18 17:29   ` [bug#58660] [PATCH v2 1/3] etc: teams: Add 'show' subcommand Mathieu Othacehe
2022-11-21 16:00     ` zimoun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6yswb4b.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=58660@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).