From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cKE6MXyjyGM85QAAbAwnHQ (envelope-from ) for ; Thu, 19 Jan 2023 02:57:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iB9VMHyjyGObGAEAG6o9tA (envelope-from ) for ; Thu, 19 Jan 2023 02:57:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 992F21F850 for ; Thu, 19 Jan 2023 02:57:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIKAq-0002Ro-5k; Wed, 18 Jan 2023 20:57:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIKAo-0002RA-9S for guix-patches@gnu.org; Wed, 18 Jan 2023 20:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIKAo-0005zQ-1p for guix-patches@gnu.org; Wed, 18 Jan 2023 20:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIKAn-00028f-UO for guix-patches@gnu.org; Wed, 18 Jan 2023 20:57:01 -0500 Subject: bug#60802: [PATCH 0/2] Remove unsupported u-boot-malta package Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 19 Jan 2023 01:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60802 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 60802-done@debbugs.gnu.org Mail-Followup-To: 60802@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 60802-done@debbugs.gnu.org id=D60802.16740933688127 (code D ref 60802); Thu, 19 Jan 2023 01:57:01 +0000 Received: (at 60802-done) by debbugs.gnu.org; 19 Jan 2023 01:56:08 +0000 Received: from localhost ([127.0.0.1]:42158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIK9w-000271-9P for submit@debbugs.gnu.org; Wed, 18 Jan 2023 20:56:08 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:35648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIK9u-00026d-O7 for 60802-done@debbugs.gnu.org; Wed, 18 Jan 2023 20:56:07 -0500 Received: by mail-qt1-f169.google.com with SMTP id g9so526546qtu.2 for <60802-done@debbugs.gnu.org>; Wed, 18 Jan 2023 17:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=SY3hJGatEQy7sCCvv9pNjUqUipIJOYJgOWr14hA3soY=; b=i3/NKYOHOGt3T7BcyCMfeygZSVuugfiz9ahoFlcfVWf+tyLc4/G83WpuwqtpkBxBru pDMJ8oUq7L0YPfHv/W5+vjVEbTnnI/tadztYrTIgHSiv2cYZSLjq1q02UFjeLHJwnvUU lB8g2F4WeUTcKCA7m4XkpYZP1il9kgVvCfX/CLs+HagbVheY5onTFsHKa4ZUOdAsg/wY RAzJm0hXBfQ/vBWEg8RmfSp4gQDK/JiJFVY9cJvAYM0P1gl+Li5kfx27qbjvHxIQ18Qt 3BXUiwpIKmmklJd0fbzD09Lw9rGTC0t2WkiRQWELyIkyOT2rt5bIslNqKzWAiNpnYRPJ GeiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SY3hJGatEQy7sCCvv9pNjUqUipIJOYJgOWr14hA3soY=; b=p2IJMHxa6V9H1Q/AtQe8AEbdkWRY2Jj6Qo3tw2Ro1NpeEbsd1y6s52iYU3XsrlMxdS bmW7FpiYSXbqUl1OSE1zx9hqvNy/t+yNydUQK92+By5/GfohiJGZ0A93VAQiL4VnoYIt Vu8t8UkFW2r6AGs6S+y+GHwBLrA2CIxx55DgGnletVee7hhc1q//MZXaWDLRwvGVN5ui qDdp2nrM75VPknIC0iFq5DWZLSsRt3YB1oPNvmeYYxqLc75XeP5qrK5sEHlK2rFFQHAv 9O1avwpPvChzRnIt4rd4g/DHsDawJz+rWj3NoRgni3Zu7Vt3wRvE/MIDxsJll9ljOac5 MPNQ== X-Gm-Message-State: AFqh2kqNK7Myd/FC4Dnt2TJWnGXSmN5wfN7URREO5lTC49INWxdXhlIs 0nJyEC7oSdLYPZ3BCfh46oE= X-Google-Smtp-Source: AMrXdXt0DksmymTcePMOU46VEbmC5MUVY5TLCq0FzF1y6T+cNgF8Y9ZzPRuFeflMidmR6r5+8GGxuw== X-Received: by 2002:a05:622a:1c15:b0:3b6:8d71:fd2b with SMTP id bq21-20020a05622a1c1500b003b68d71fd2bmr1315835qtb.48.1674093361143; Wed, 18 Jan 2023 17:56:01 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id j19-20020a05620a411300b00704c1f4e756sm23153599qko.14.2023.01.18.17.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 17:56:00 -0800 (PST) From: Maxim Cournoyer References: <20230114041903.7121-2-maxim.cournoyer@gmail.com> <87mt6l9oc6.fsf@gnu.org> Date: Wed, 18 Jan 2023 20:55:59 -0500 In-Reply-To: <87mt6l9oc6.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 14 Jan 2023 15:34:49 +0100") Message-ID: <87h6wne18w.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674093436; a=rsa-sha256; cv=none; b=FFQeSzTop7JGgSfZqE6qBAcvgT4DUv71ZIvmzM4LsLw/DD30oTvtr3wxid07/S8wOxOj94 gmuj/OtBDMJzzMsVDXKgV7vj7q3pA2ONE5vrFmzGGN16eeMX6/X2Bn4vA0N3wkAF2GGXb0 DzOE3UOl9TrC9mv5lsdbfhqBtWXdl0UjHudQhf62cMaSp8wEPCuN32mAfkuB3P0VaStDZD 1qUO7wgF4RtZXkuUTeL1SVLufmb+n91lNu65EEsUGb6GMPx9OFckzDYOJmDK7vohYyKb5p 74HFsuyadF79ljozIQQpcJTb82uYyWbbeugnYwIxLnbLknJr3eyisGEutDM1ow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="i3/NKYOH"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674093436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SY3hJGatEQy7sCCvv9pNjUqUipIJOYJgOWr14hA3soY=; b=bDuChZ8RJDYzdfYCLpH/M0Qa1g2WjgZpr44P7pG20NWqOoBkQekZKc+AazZbhchYH6hsgt r6U/T2kz9PeDrwiGNMApbWWcssSZssTZVZxjHTIZBC1bxbjY2OXo+7ooJZaBWAvdpODszt PffjYvkf3FydnJoG+DFoov4yH1GSqhAJSR2qHqv7wj50q058kOtET+4hqL47N20uv8PjVs /FMkxUynv6KcZje86siFJYzgoR6qMLSldz7fGYobsiETCe/MnTVA363q29sIgAusL/hDoU X3DnigISj/Nf2MFuKE71iS6vrC9a3OhVV6Tf5gtahz4Zvy9zhvMVseUZhwhgxw== X-Spam-Score: 6.38 X-Migadu-Queue-Id: 992F21F850 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="i3/NKYOH"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: 6.38 X-TUID: cd/5qX2I8Hnt Hello, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> This was motivated by #60786, which produced a cryptic, hard to understa= nd >> backtrace. >> >> * guix/platform.scm (&platform-not-found-error): New exception type. >> (make-platform-not-found-error): New exception constructor. >> (platform-not-found-error?): New predicate. >> (false-if-platform-not-found): New syntax. >> (lookup-platform-by-system): Raise an exception when no platform is foun= d. >> Update documentation. >> (lookup-platform-by-target): Likewise. >> (lookup-platform-by-target-or-system): Likewise, and guard lookup calls = with >> false-if-platform-not-found. > > Sounds like a good idea! > >> +++ b/guix/platform.scm >> @@ -21,6 +21,7 @@ (define-module (guix platform) >> #:use-module (guix memoization) >> #:use-module (guix records) >> #:use-module (guix ui) >> + #:use-module (ice-9 exceptions) > > So far the we use (srfi srfi-35) exclusively to define condition types; > I think we should do the same here, for consistency. > >> + &platform-not-found-error >> + make-platform-not-found-error > > The constructor doesn=E2=80=99t need to be exposed. > >> +;;; >> +;;; Exceptions. >> +;;; >> +(define-exception-type &platform-not-found-error &error >> + make-platform-not-found-error platform-not-found-error?) > > So this would become (define-condition-type =E2=80=A6). > > Otherwise LGTM, thanks! The latest version incorporate these changes and use srfi-34/35 as is currently custom in Guix. I've now applied it. --=20 Thanks, Maxim