From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OLKHMxH25GNcagAAbAwnHQ (envelope-from ) for ; Thu, 09 Feb 2023 14:33:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QPN1MxH25GN/SgEAauVa8A (envelope-from ) for ; Thu, 09 Feb 2023 14:33:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE67E3D914 for ; Thu, 9 Feb 2023 14:33:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ72O-0008Gt-N5; Thu, 09 Feb 2023 08:32:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ71u-0008Cd-Nj for guix-patches@gnu.org; Thu, 09 Feb 2023 08:32:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ71u-000257-FO for guix-patches@gnu.org; Thu, 09 Feb 2023 08:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQ71u-0004Mg-2t for guix-patches@gnu.org; Thu, 09 Feb 2023 08:32:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60788] [PATCH] services: Add vnstat-service-type. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Feb 2023 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60788 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 60788@debbugs.gnu.org Received: via spool by 60788-submit@debbugs.gnu.org id=B60788.167594951716766 (code B ref 60788); Thu, 09 Feb 2023 13:32:02 +0000 Received: (at 60788) by debbugs.gnu.org; 9 Feb 2023 13:31:57 +0000 Received: from localhost ([127.0.0.1]:57933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ71o-0004MM-Sa for submit@debbugs.gnu.org; Thu, 09 Feb 2023 08:31:57 -0500 Received: from mail-vk1-f177.google.com ([209.85.221.177]:46941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ71n-0004M6-IM for 60788@debbugs.gnu.org; Thu, 09 Feb 2023 08:31:55 -0500 Received: by mail-vk1-f177.google.com with SMTP id t190so912565vkb.13 for <60788@debbugs.gnu.org>; Thu, 09 Feb 2023 05:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vCfAP2ugkK4d7LfriweFYZsDUZzl0iJ5lQMkXYnLW+I=; b=IWXt2Q47wC4r+/r/bBm6Vb7WdwkGH5U7RfC5M5x37D3TNuT9jRQkFNG1fSCv4hEVtI ifsk//2vib8XoMikiBjIBvOwrCLFHKDwa3Ymf7P+anG38l0Ok+zNaKSUyOTj4xYDn+mg mLUECdYd5sW7TTGgztbmq7K9ePuKuHOFC7ofmii7Wfgi+m55S2nhGeeS/xo4MtR8RYNN a098WrIzrBCcA+aRITzatxXb0o2kBLqSbAml/mNYesHBt086tsfzfkWsQa2tcQ8o580r C1wr7zUa3uesIMEpU5SuidfIQ5Q2T/m96ewrknXozqbav76SsLQeLwUFreOTUogCGUaI qUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vCfAP2ugkK4d7LfriweFYZsDUZzl0iJ5lQMkXYnLW+I=; b=AJG7cwcrBv8KwOHjofyuMTLqJu350ijnHMz7PTSWQWx9eP2AiUxDmRLze7+b6vbbtA c/R0qTx1FJ0CJaQ6iAbgLqPE99Douo23HhEOsUheOVSbNcHAif46yc9zTK7evXx8JVdO tutc03QqHaDRvfGrvWu8Pkk7S59Pyu0WDbXI3EHJaEYkLh+mkKGEg9DyaLv4jkQbGRLR zLzbbbASWO9vLiEV145px5+DCSxGmmiihLEo3Exrv4Fg60+1JldNs9ssBWykr9t+PDiO DmpQ4myyjAnYJurOIM6co4Bwki5+wABf+zVISv7pwZGjQMX00fc5ZVF7EvdJ9zYdMeJR TjnQ== X-Gm-Message-State: AO0yUKUz+7XEdWFosstKJzo6fwyDUaxc3qWEX/TClwddfCIVIjRN7zEj DPjf3W/ZbqlckhS1vQNi5+sg0sGaj4Kh1w== X-Google-Smtp-Source: AK7set9o+gffN5EFB9QsoK/8XkWe3uRkQl9xYdyuexcYhvSnt7YwPZSrcmxojFabZXuyp9wEticFZg== X-Received: by 2002:a05:6122:d0d:b0:3e9:ffa6:71bd with SMTP id az13-20020a0561220d0d00b003e9ffa671bdmr4213540vkb.13.1675949509592; Thu, 09 Feb 2023 05:31:49 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id t66-20020a374645000000b007203bbbbb31sm1359487qka.47.2023.02.09.05.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 05:31:49 -0800 (PST) From: Maxim Cournoyer References: <95b646eb6b23dec213cba43b6e4e7ddc4a601d0f.1673640404.git.mirai@makinata.eu> <8b62c1b5643a09163b53af4bf03bb12862770b50.1675779899.git.mirai@makinata.eu> <87357fjyuc.fsf_-_@gmail.com> Date: Thu, 09 Feb 2023 08:31:48 -0500 In-Reply-To: (Bruno Victal's message of "Thu, 9 Feb 2023 04:19:40 +0000") Message-ID: <87h6vvge2j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675949585; a=rsa-sha256; cv=none; b=gIHCdkRKMYQNj+AoblfG84buLZPDkeyt5C518qK5umiDxV35XIVIhGCjYafGDglaH6eFK/ lOK3a7RwHy+bscl34Ivv0UVyqgACc9UF2AH9DYxDQgFrYgC8TvcsUF5eoWxg8YzQvxn4ih OpW0hvvE919iKdhpIuCUhWrO/udmYK9y8XRGdAhHMmX/X2/X/F111chw4Ar3DtUz5ivcU4 luVE8tbGLmd7+GfS57dbMArUsB0ObrrzNVrBTZQomhwe1l7ncL+l7fnzJAdoMsk4vxoa4c dfv83lyXs/rm6dIdI+MvFMznfU8k3oN3JR2xyAacDarkAr8SB5V4iHiaFJNctw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IWXt2Q47; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675949585; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vCfAP2ugkK4d7LfriweFYZsDUZzl0iJ5lQMkXYnLW+I=; b=F6VPv4CD4vNnPwh7jmUhgzr4++wF8IVwHLSjk+pLSpgn7UJeGkLY15J85+XNd32SBLryJ0 jhSwVX7QgwUwZ6aHIaL3QLdOi+Y6RrY/q+B8GgqLKRyj/zQAncn0YgQzdSYTeoiVf121A+ boTnvi7Kzk+EBweevD67ZSra6WMvk8QOr5NtbDnuDNof8z9/qlwIZMRVlLt8lckA3brUsB +IZD4olYxyPLUYt8I78a/sK07o2JMb2Z+7qwy1aj6jpxeogDiLqC3cqFdUzwtBsIdcQFRJ y51V23icVMCGZFmReOK9Wv0s73Sl83en2EWXQNbgOSV2rxm8wF6IbyHYIylFNg== X-Migadu-Spam-Score: 6.90 X-Spam-Score: 6.90 X-Migadu-Queue-Id: AE67E3D914 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IWXt2Q47; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-TUID: z77+HtYbomHM Hi Bruno, Bruno Victal writes: > Hi Maxim, > > On 2023-02-09 03:34, Maxim Cournoyer wrote: >> Two remaining comments from me: >> >> 1. I'd normalize all the configuration field names to lowercase, so >> max-BW and use-UTC? would become max-bw and use-utc?, for example. > > No, this is intentional so that uglify+case-conversion yields correct configuration directives. OK; the case conversion could be special-cased (max-bw -> max-BW, use-utc? -> utc-UTC?) in the uglify+case-conversion logic. But it seems that vnstat doesn't care about case when parsing its options; it uses strcasecmp, which ignores the case of the characters per 'man 3 strcasecmp' [0]. [0] https://github.com/vergoh/vnstat/blob/master/src/cfg.c#L149 >> 2. I'd add a simple example vnstat usage example to the manual. > > The service is "ready to be used" with the default values, so I didn't think > it'd add much value adding an example here. Do you think we should add one? I think so; with so many switches it can appear intimidating; but a minimal working example would show to users that they can start simple. -- Thanks, Maxim