From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wG6xJPYCXWS7fwEASxT56A (envelope-from ) for ; Thu, 11 May 2023 17:00:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YH6xJPYCXWRvXgEAauVa8A (envelope-from ) for ; Thu, 11 May 2023 17:00:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43C4A27F14 for ; Thu, 11 May 2023 17:00:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px7m0-00012w-V5; Thu, 11 May 2023 11:00:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px7ly-00012i-Hx for guix-patches@gnu.org; Thu, 11 May 2023 11:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1px7ly-00080A-7C for guix-patches@gnu.org; Thu, 11 May 2023 11:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1px7ly-0003Qr-2n for guix-patches@gnu.org; Thu, 11 May 2023 11:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63416] [PATCH 0/2] Fix more derivation builder gexp issues. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 May 2023 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63416 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63416@debbugs.gnu.org Received: via spool by 63416-submit@debbugs.gnu.org id=B63416.168381714813097 (code B ref 63416); Thu, 11 May 2023 15:00:02 +0000 Received: (at 63416) by debbugs.gnu.org; 11 May 2023 14:59:08 +0000 Received: from localhost ([127.0.0.1]:53129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px7l5-0003PA-Vz for submit@debbugs.gnu.org; Thu, 11 May 2023 10:59:08 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px7l4-0003P2-I5 for 63416@debbugs.gnu.org; Thu, 11 May 2023 10:59:07 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157]) by mira.cbaines.net (Postfix) with ESMTPSA id DFFD327BBEE; Thu, 11 May 2023 15:59:05 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 91448ff3; Thu, 11 May 2023 14:59:05 +0000 (UTC) References: <87o7ms1if5.fsf@cbaines.net> <87fs835eqn.fsf_-_@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Thu, 11 May 2023 15:57:20 +0100 In-reply-to: <87fs835eqn.fsf_-_@gnu.org> Message-ID: <87h6sizzgp.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683817206; a=rsa-sha256; cv=none; b=CQ00A4tWvXcaDPpuQJfJYlURD8+uG9M5e/5IucQE3uBMMKsLH/Aed9nQxBMxz++Unpapgz sfopTEeYjxXgd8doTwExJ9LejYN61SXEF4hFOf0yGDOG9EJyi7sPVqsab1W7Z7NLMB59+c 6u86zFV887QPUROKPEKBNIwLCh3VknvAmJTllZwPrWKO582pTWQSnwVtFknvSKrqrmEbwW GH2gQLiDvV516/yUwaGu33U5VWYD9USr6qLcgqlp9kbFyya74kHtGvIFPcaS9Bea1y/uq3 A7rlrStjhhWzbfekJn3kuvCd7Zb9IVAGxLmfMn2wRWFzAkybHoh3JKO4HVPI0A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683817206; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=o6A/8nV2OdV6yMQ7lP5yjxcCxAl48Q/lGKgtSa15Ruk=; b=R1baomGkC4kFZy5eyjaS1G7gJ0rCpax4vtzUNTBjJVGP5k2XLHZ+wJIXGZ3LpGsglCxqC9 SfmN90BCKcFol+x/jXsAiNpXvgROH/dlhkopIWbishqYMHxN7K3uFed7sTjRABntfqd09v PnXinc89wPo97zQx1fbhbZ2VNbs3cw7muCdziWGPWsn6x9ZoUyNi3lmSuRDU0vCLvCkzjw 15g0oaqTSB/M4/9ouJDykybGefLXmWLa86udUtlTlsH4wDI8QqXk0IYb4WWFDtmShiCakv TewVHAZn72UTmd84jXmNdbJLxBK3DMLIWhowTPlgw05l081hEMWH0/+fMb6u2Q== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.78 X-Spam-Score: -3.78 X-Migadu-Queue-Id: 43C4A27F14 X-TUID: KTXA1oSjrHfx --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> As this seems to be generating broken derivations for i586-gnu otherwise. > > =E2=80=9CSeems=E2=80=9D isn=E2=80=99t confidence-inspiring. ;-) > > Here=E2=80=99s one: > > $ ./pre-inst-env guix build gccgo -s i586-gnu -d=20 > /gnu/store/yzlmgxq20bk9xcbksi7q1f839056wzhr-gccgo-12.3.0.drv > $ guix gc --references /gnu/store/yzlmgxq20bk9xcbksi7q1f839056wzhr-gccgo-= 12.3.0.drv |grep builder > /gnu/store/jizw9gjvzb21jm7q7xlm71pw6fr24hhv-gccgo-12.3.0-builder > $ grep -q '#<' /gnu/store/jizw9gjvzb21jm7q7xlm71pw6fr24hhv-gccgo-12.3.0-b= uilder ; echo $? > 0 > >> * gnu/packages/gcc.scm (custom-gcc): Use gexp's for the generated package >> arguments. > > [...] > >> As otherwise this seems to generate broken derivations for i586-gnu. >> >> * gnu/packages/gcc.scm (make-gccgo): Use gexp's for the package argument= s. > > > [...] > >> +++ b/gnu/packages/gcc.scm >> @@ -1156,34 +1156,34 @@ (define (make-gccgo gcc) >> (arguments >> (substitute-keyword-arguments (package-arguments gccgo) >> ((#:phases phases) >> - `(modify-phases ,phases >> - (add-after 'install 'wrap-go-with-tool-path > > If =E2=80=98phases=E2=80=99 might be a gexp, then this should be a gexp a= s well. > > Put differently, if one of the gcc* packages starts using gexps, then > all those that inherit from it should switch as well. > > Since =E2=80=98gcc-11=E2=80=99 uses gexps (only when targeting the Hurd),= all the other > ones should use gexps. That probably includes all those in gcc.scm and > all those in commencement.scm. Yep, I think these changes were sufficient, but I missed replacing a few unquote bits with ungexp, so as QA shows this affected a bunch of derivations for all systems. I've fixed those bits now and sent a v2. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRdArZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd/OQ//fpydlrGI/TnXajhiHhaNyad4/nAfztae Ggirl1ATCy4eljL92k4f5ceFkXsATN52fEUXIhvczkVO1HlwHi6nrv070N8+O2SO 5qjcpP8aZrufx0DuZlZAETYGmCxw6LZWKxBBFyf+Xe0pXawmboUq4RfKAzch7fF6 lc3yJC/ZvMuLs7BzfdSirefJBZOxrLXEMD7+kkfl9+aTHbo3e/COsjMlVwJ6kJ4Z KvXrWwUS/eQ6YtBtjsHlyWEuGktU9HkqIR1dkcXkgce0FjHXwDmQsp1MYlZ1D4h6 +qaunKOFps07m3IT1+p9OpSEiUNG4PKI8jkAC3CHtEG6Abt09XK+wNGEY1G6cY7h keHTpcHDXVep5cCILx7qLdd7scFO4H9mhjPEQUJyJIlRTbmXUagGk/QnvQOa6oaI AjNI91x5rcHlf+ru+/Fy6Z3vBpTJGWne3NMVSt6wS9h+WamOuTjbECpPb24uipzL Ubm0zXJAMrJgCe8EiGOjSNPIcQc0KZw/3DF6GpsjPXFFnxsYqNNIFu8oyfsbD3ua g8+uc58FFeylNYHCXcaBCMliylXpD+374zXRCWO90JKawblbnwuf9xY/5PyDviMq L8qYgMUsu7+6FAKyJt6Z/23uEClrQEJCw5pzUxTSkVRZSLp54OOOfaR0IC7aP9lC XgPpGCccC4I= =GH1z -----END PGP SIGNATURE----- --=-=-=--