From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Fabio Natali <me@fabionatali.com>
Cc: 65150@debbugs.gnu.org
Subject: [bug#65150] [PATCH] gnu: emacs-hide-mode-line: Update to 1.0.3-0.bc5d293.
Date: Mon, 21 Aug 2023 12:59:47 +0800 [thread overview]
Message-ID: <87h6otgfcs.wl-hako@ultrarare.space> (raw)
In-Reply-To: <b37a17e5afd25bf0bab4013a9d0a1d39762d2f1b.1691502389.git.me@fabionatali.com>
Hi Fabio,
On Tue, 08 Aug 2023 21:53:40 +0800,
Fabio Natali wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-hide-mode-line): Update to 1.0.3-0.bc5d293.
> ---
>
> Hi, emacs-hide-mode-line 1.0.2 has a couple of issues that were solved upstream as part of the 1.0.3 release. See the links below for further info.
>
> https://github.com/hlissner/emacs-hide-mode-line/commit/daa4908a14c647382cb24fa2f7ceaa3aba3517d4
> https://github.com/hlissner/emacs-hide-mode-line/commit/cc81ba34f49d91e885fc0b0e539d68ca9368b5f5
>
> Unfortunately, no Git tag has been created for version 1.0.3. I've contacted the Author in case they might be willing to create a 1.0.3 tag - but in the meantime I thought of bumping the Guix package using the commit.
>
> Hope this is fine, cheers, Fabio.
>
> gnu/packages/emacs-xyz.scm | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed3d89d51f..12ef23b1cf 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -34121,25 +34121,27 @@ (define-public emacs-parseclj
> (license license:gpl3+)))
>
> (define-public emacs-hide-mode-line
> - (package
> - (name "emacs-hide-mode-line")
> - (version "1.0.2")
> - (source (origin
> + (let ((commit "bc5d293576c5e08c29e694078b96a5ed85631942")
> + (revision "0"))
> + (package
> + (name "emacs-hide-mode-line")
> + (version (git-version "1.0.3" revision commit))
> + (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://github.com/hlissner/emacs-hide-mode-line")
> - (commit (string-append "v" version))))
> + (commit commit)))
> (file-name (git-file-name name version))
> (sha256
> (base32
> - "0dfzjgxfkcw4wisbyldsm1km18pfp9j8xgadn6qnsz11l55bpgyp"))))
> - (build-system emacs-build-system)
> - (synopsis "Emacs plugin that hides the mode-line")
> - (description "A minor mode that hides the mode-line in your current
> + "12mfhg0r3gvy59ijy44vsircn251nmisp04k9vvgd2yhykpsr1j6"))))
> + (build-system emacs-build-system)
> + (synopsis "Emacs plugin that hides the mode-line")
> + (description "A minor mode that hides the mode-line in your current
> buffer. It can be used to toggle an alternative mode-line, toggle its visibility,
> or simply disable the mode-line in buffers where it is not very useful.")
> - (home-page "https://github.com/hlissner/emacs-hide-mode-line")
> - (license license:expat)))
> + (home-page "https://github.com/hlissner/emacs-hide-mode-line")
> + (license license:expat))))
>
> (define-public emacs-helm-cider
> (package
>
> base-commit: 782ef67a59f4b564f16101cf23c30a3777b3f734
> --
> 2.41.0
Since the commit refers to a (untagged) release, I'd prefer using the
version string directly instead of a git-version, and adding a comment
for the commit. You can take a look at emacs-fennel-mode for an
example.
There's also identation issue, which can be fixed with `guix style':
$ ./pre-inst-env guix style emacs-hide-mode-line
Thanks
next prev parent reply other threads:[~2023-08-21 5:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 13:53 [bug#65150] [PATCH] gnu: emacs-hide-mode-line: Update to 1.0.3-0.bc5d293 Fabio Natali
2023-08-21 4:59 ` Hilton Chain via Guix-patches via [this message]
2023-08-21 11:01 ` Fabio Natali
2023-08-27 3:53 ` bug#65150: " Hilton Chain via Guix-patches via
2023-08-27 9:22 ` [bug#65150] " Fabio Natali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6otgfcs.wl-hako@ultrarare.space \
--to=guix-patches@gnu.org \
--cc=65150@debbugs.gnu.org \
--cc=hako@ultrarare.space \
--cc=me@fabionatali.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).